src/libplatform/tracing/trace-writer.h - Issue 2367603002: [tracing] Support ConvertableToTraceFormat argument type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/libplatform/tracing/trace-writer.h

Issue 2367603002: [tracing] Support ConvertableToTraceFormat argument type. (Closed)

Patch Set: Fix layout tests failures & reland. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/libplatform/tracing/trace-writer.h

diff --git a/src/libplatform/tracing/trace-writer.h b/src/libplatform/tracing/trace-writer.h

index 963fc6a64dc262172db2949cc4f4f568d4fae8b1..43d7cb6a9063f8830da30147075d916efa60b73e 100644

--- a/src/libplatform/tracing/trace-writer.h

+++ b/src/libplatform/tracing/trace-writer.h

@@ -20,6 +20,7 @@ class JSONTraceWriter : public TraceWriter {

private:

void AppendArgValue(uint8_t type, TraceObject::ArgValue value);

+ void AppendArgValue(v8::ConvertableToTraceFormat*);

std::ostream& stream_;

bool append_comma_ = false;

« no previous file with comments | « src/libplatform/tracing/trace-object.cc ('k') | src/libplatform/tracing/trace-writer.cc » ('j') | no next file with comments »