Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: include/v8.h

Issue 23676007: remove commented out code in v8.h (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 11aa47394f55d63711b93708c6ff7252a8f651bf..55a8ea6327d258ba724d87da5de9d8d2226f0128 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -544,14 +544,6 @@ template <class T, class M> class Persistent {
Copy(that);
return *this;
}
- /**
- * The destructor will dispose the Persistent based on the
- * kResetInDestructor flags in the traits class. Since not calling dispose
- * can result in a memory leak, it is recommended to always set this flag.
- */
-// V8_INLINE(~Persistent()) {
-// if (M::kResetInDestructor) Reset();
-// }
/**
* If non-empty, destroy the underlying storage cell
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698