Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2367573002: Do follow-up refactoring in rebaseline.py in _run_in_parallel and _serial_commands. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do follow-up refactoring in rebaseline.py in _run_in_parallel and _serial_commands. The purpose of this CL is to make the code a little simpler and easier to read. Committed: https://crrev.com/c76a2deae879d652b690d9f4d30e8c26f4c22b30 Cr-Commit-Position: refs/heads/master@{#420580}

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 3 chunks +16 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
4 years, 3 months ago (2016-09-22 22:06:20 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-22 23:14:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367573002/20001
4 years, 3 months ago (2016-09-23 04:02:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 05:06:05 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 05:07:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c76a2deae879d652b690d9f4d30e8c26f4c22b30
Cr-Commit-Position: refs/heads/master@{#420580}

Powered by Google App Engine
This is Rietveld 408576698