Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Unified Diff: third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp

Issue 2367543004: Extended implementation to use interface as arguments (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
diff --git a/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp b/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
index 546692b35fc4abfd181efb322954e10723ddcb19..8477008a15e9d3ac081de90b0b33954b4ebe90d1 100644
--- a/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
+++ b/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
@@ -7,6 +7,8 @@
#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8TestCallback.h"
+#include "bindings/core/v8/V8TestInterfaceCallback.h"
+#include "core/html/HTMLDivElement.h"
namespace blink {
@@ -25,4 +27,12 @@ String CallbackFunctionTest::testCallback(ScriptState* scriptState, V8TestCallba
return String("Error!");
}
+void CallbackFunctionTest::testInterfaceCallback(ScriptState* scriptState, V8TestInterfaceCallback* callback, HeapVector<Member<HTMLDivElement>>& div, ExceptionState& exceptionState)
bashi 2016/09/23 02:16:05 div -> divElements ?
lkawai 2016/09/23 02:43:42 Done.
+{
+ ScriptWrappable* scriptWrappable;
peria 2016/09/23 02:50:05 initialize |scriptWrappable|
lkawai 2016/09/23 05:35:45 In the past CL, I got a comment that initializatio
peria 2016/09/23 15:34:49 All variables must be initialized at their declara
+
+ callback->call(scriptState, scriptWrappable = nullptr, div);
+ return;
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698