Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 236753004: Re-land "Improve support for :read-only and :read-write pseudoclasses". (Closed)

Created:
6 years, 8 months ago by andersr
Modified:
6 years, 8 months ago
Reviewers:
esprehn, eae
CC:
blink-reviews, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, adamk+blink_chromium.org, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Re-land "Improve support for :read-only and :read-write pseudoclasses". The fix was reverted because it appeared to cause a security issue. (It didn't). Previous review: https://codereview.chromium.org/148223004 BUG=338309, 353143 TEST=fast/css/readwrite-contenteditable.html fast/css/readwrite-contenteditable-recalc.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -9 lines) Patch
A LayoutTests/fast/css/readwrite-contenteditable.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/readwrite-contenteditable-expected.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/readwrite-contenteditable-recalc.html View 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/readwrite-contenteditable-recalc-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/input-live-pseudo-selectors.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/resources/input-live-pseudo-selectors.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/resources/live-pseudo-selectors.css View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/resources/select-live-pseudo-selectors.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/resources/textarea-live-pseudo-selectors.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/select-live-pseudo-selectors.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/textarea-live-pseudo-selectors.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
andersr
6 years, 8 months ago (2014-04-14 13:52:58 UTC) #1
eae
LGTM
6 years, 8 months ago (2014-04-14 15:54:25 UTC) #2
andersr
The CQ bit was checked by andersr@opera.com
6 years, 8 months ago (2014-04-15 10:18:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/236753004/1
6 years, 8 months ago (2014-04-15 10:19:01 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 11:26:52 UTC) #5
Message was sent while issue was closed. 
Change committed as 171564

Powered by Google App Engine
This is Rietveld 408576698