Issue 236753002: Return int64_t instead of intptr_t for RootRegisterDelta and support x32 as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 236753002: Return int64_t instead of intptr_t for RootRegisterDelta and support x32 as well. (Closed)

Created:
6 years, 8 months ago by haitao.feng

Modified:
6 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Return int64_t instead of intptr_t for RootRegisterDelta and support x32 as well. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20863

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -9 lines)			Patch
	M	src/x64/macro-assembler-x64.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/x64/macro-assembler-x64.cc	View		7 chunks	+19 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

haitao.feng

For x32, we could not use intptr_t for the delta as the whole address space ...

6 years, 8 months ago (2014-04-14 11:20:41 UTC) #1

haitao.feng

6 years, 8 months ago (2014-04-17 23:25:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20863 (presubmit successful).