Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: components/certificate_transparency/mock_log_dns_traffic.h

Issue 2367523002: Merge LogDnsClient's QueryLeafIndex and QueryAuditProof methods (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/certificate_transparency/mock_log_dns_traffic.h
diff --git a/components/certificate_transparency/mock_log_dns_traffic.h b/components/certificate_transparency/mock_log_dns_traffic.h
index f91e66824de64b4a0b1d63914ca54da1977eb80a..52421cfd884b74cf5cccfb8fb875cedd3885f4b4 100644
--- a/components/certificate_transparency/mock_log_dns_traffic.h
+++ b/components/certificate_transparency/mock_log_dns_traffic.h
@@ -98,10 +98,15 @@ class MockLogDnsTraffic {
// A description of such a request and response can be seen here:
// https://github.com/google/certificate-transparency-rfcs/blob/c8844de6bd0b5d3d16bac79865e6edef533d760b/dns/draft-ct-over-dns.md#hash-query-hashquery
void ExpectLeafIndexRequestAndResponse(base::StringPiece qname,
Eran Messeri 2016/09/23 12:59:32 Given the method you've added I suggest removing t
Rob Percival 2016/09/27 17:44:17 I hadn't actually meant to add this one - I was ju
base::StringPiece leaf_index);
// Expect a CT DNS request for the domain |qname|.
+ // Such a request will receive a DNS response containing |leaf_index| as a
+ // string.
+ void ExpectLeafIndexRequestAndResponse(base::StringPiece qname,
+ uint64_t leaf_index);
+ // Expect a CT DNS request for the domain |qname|.
// Such a request will receive a DNS response containing the inclusion proof
// nodes between |audit_path_start| and |audit_path_end|.
// A description of such a request and response can be seen here:
// https://github.com/google/certificate-transparency-rfcs/blob/c8844de6bd0b5d3d16bac79865e6edef533d760b/dns/draft-ct-over-dns.md#tree-query-treequery
void ExpectAuditProofRequestAndResponse(

Powered by Google App Engine
This is Rietveld 408576698