Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2367513002: GN: build skiaserve (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: build skiaserve I trimmed the libmicrohttpd sources and defines down to the minimum needed to build and run. This builds and runs on Linux and Android for me. Request.h was missing an include for SkTypes.h, which supplies the default for SK_GPU_SUPPORTED if not otherwise defined. To build on Android, exit() -> _exit(). build.py was unused. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2367513002 NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/ecbc526418414f6f9d29b176ea0ad8037fff2e2d

Patch Set 1 #

Patch Set 2 : building #

Patch Set 3 : trim sources #

Patch Set 4 : cleanup #

Patch Set 5 : _exit #

Patch Set 6 : sys/socket #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -39 lines) Patch
M BUILD.gn View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/libmicrohttpd/BUILD.gn View 1 2 3 4 5 1 chunk +36 lines, -0 lines 0 comments Download
D third_party/libmicrohttpd/build.py View 1 2 3 1 chunk +0 lines, -38 lines 0 comments Download
M tools/skiaserve/Request.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/skiaserve/urlhandlers/QuitHandler.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (19 generated)
mtklein_C
4 years, 3 months ago (2016-09-22 17:46:14 UTC) #15
jcgregorio
lgtm
4 years, 3 months ago (2016-09-22 17:50:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367513002/100001
4 years, 3 months ago (2016-09-22 18:04:54 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 18:51:26 UTC) #23
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/ecbc526418414f6f9d29b176ea0ad8037fff2e2d

Powered by Google App Engine
This is Rietveld 408576698