|
|
Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 3 months ago CC:
chromium-reviews, blink-reviews, xidachen, xlai (Olivia), Zhenyao Mo, Kai Ninomiya Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionStarted adding links for Canvas and its 2D and WebGL contexts.
BUG=none
NOTRY=true
Committed: https://crrev.com/331f8f0d66f4726b3eb7d2e9f730c15d84f13e2c
Cr-Commit-Position: refs/heads/master@{#420696}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Preemptive rebase. #Patch Set 3 : Rebased. #Messages
Total messages: 22 (11 generated)
kbr@chromium.org changed reviewers: + jochen@chromium.org, junov@chromium.org
Jochen, Justin: PTAL Others: comments welcome. Please help fill this out after it lands; needs more links like OffscreenCanvas, ImageBitmapRenderingContext, etc. Thanks.
Awesome, thanks I defer to Justin for correctness. rs lgtm
looks good. https://codereview.chromium.org/2367493003/diff/1/third_party/WebKit/Source/S... File third_party/WebKit/Source/SpecMapping.md (right): https://codereview.chromium.org/2367493003/diff/1/third_party/WebKit/Source/S... third_party/WebKit/Source/SpecMapping.md:35: [modules/canvas2d](https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/canvas2d/). There is also the bitmap renderer context that lives https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/imageb...
On 2016/09/22 20:40:45, Justin Novosad wrote: > looks good. > > https://codereview.chromium.org/2367493003/diff/1/third_party/WebKit/Source/S... > File third_party/WebKit/Source/SpecMapping.md (right): > > https://codereview.chromium.org/2367493003/diff/1/third_party/WebKit/Source/S... > third_party/WebKit/Source/SpecMapping.md:35: > [modules/canvas2d](https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/canvas2d/). > There is also the bitmap renderer context that lives > https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/imageb... Could you add that one after this lands? Thanks.
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2367493003/#ps20001 (title: "Preemptive rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Started adding links for Canvas and its 2D and WebGL contexts. BUG=none ========== to ========== Started adding links for Canvas and its 2D and WebGL contexts. BUG=none NOTRY=true ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2367493003/#ps40001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Started adding links for Canvas and its 2D and WebGL contexts. BUG=none NOTRY=true ========== to ========== Started adding links for Canvas and its 2D and WebGL contexts. BUG=none NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Started adding links for Canvas and its 2D and WebGL contexts. BUG=none NOTRY=true ========== to ========== Started adding links for Canvas and its 2D and WebGL contexts. BUG=none NOTRY=true Committed: https://crrev.com/331f8f0d66f4726b3eb7d2e9f730c15d84f13e2c Cr-Commit-Position: refs/heads/master@{#420696} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/331f8f0d66f4726b3eb7d2e9f730c15d84f13e2c Cr-Commit-Position: refs/heads/master@{#420696} |