Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2367493003: Started adding links for Canvas and its 2D and WebGL contexts. (Closed)

Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, blink-reviews, xidachen, xlai (Olivia), Zhenyao Mo, Kai Ninomiya
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Started adding links for Canvas and its 2D and WebGL contexts. BUG=none NOTRY=true Committed: https://crrev.com/331f8f0d66f4726b3eb7d2e9f730c15d84f13e2c Cr-Commit-Position: refs/heads/master@{#420696}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Preemptive rebase. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M third_party/WebKit/Source/SpecMapping.md View 1 2 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 22 (11 generated)
Ken Russell (switch to Gerrit)
Jochen, Justin: PTAL Others: comments welcome. Please help fill this out after it lands; needs ...
4 years, 3 months ago (2016-09-22 18:27:51 UTC) #2
jochen (gone - plz use gerrit)
Awesome, thanks I defer to Justin for correctness. rs lgtm
4 years, 3 months ago (2016-09-22 18:30:37 UTC) #3
Justin Novosad
looks good. https://codereview.chromium.org/2367493003/diff/1/third_party/WebKit/Source/SpecMapping.md File third_party/WebKit/Source/SpecMapping.md (right): https://codereview.chromium.org/2367493003/diff/1/third_party/WebKit/Source/SpecMapping.md#newcode35 third_party/WebKit/Source/SpecMapping.md:35: [modules/canvas2d](https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/canvas2d/). There is also the bitmap renderer ...
4 years, 3 months ago (2016-09-22 20:40:45 UTC) #4
Ken Russell (switch to Gerrit)
On 2016/09/22 20:40:45, Justin Novosad wrote: > looks good. > > https://codereview.chromium.org/2367493003/diff/1/third_party/WebKit/Source/SpecMapping.md > File third_party/WebKit/Source/SpecMapping.md ...
4 years, 3 months ago (2016-09-23 17:48:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367493003/20001
4 years, 3 months ago (2016-09-23 17:54:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/298798)
4 years, 3 months ago (2016-09-23 19:03:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367493003/20001
4 years, 3 months ago (2016-09-23 19:14:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/265896)
4 years, 3 months ago (2016-09-23 19:21:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367493003/40001
4 years, 3 months ago (2016-09-23 19:29:52 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-23 19:35:53 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 19:39:21 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/331f8f0d66f4726b3eb7d2e9f730c15d84f13e2c
Cr-Commit-Position: refs/heads/master@{#420696}

Powered by Google App Engine
This is Rietveld 408576698