Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: src/globals.h

Issue 2367483003: Remove ARGUMENTS_VARIABLE and fix crankshaft to properly detect the arguments object and keep it al… (Closed)
Patch Set: Rebaseline more Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_GLOBALS_H_ 5 #ifndef V8_GLOBALS_H_
6 #define V8_GLOBALS_H_ 6 #define V8_GLOBALS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 952 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 } 963 }
964 UNREACHABLE(); 964 UNREACHABLE();
965 return NULL; 965 return NULL;
966 } 966 }
967 #endif 967 #endif
968 968
969 enum VariableKind : uint8_t { 969 enum VariableKind : uint8_t {
970 NORMAL_VARIABLE, 970 NORMAL_VARIABLE,
971 FUNCTION_VARIABLE, 971 FUNCTION_VARIABLE,
972 THIS_VARIABLE, 972 THIS_VARIABLE,
973 ARGUMENTS_VARIABLE,
974 SLOPPY_FUNCTION_NAME_VARIABLE, 973 SLOPPY_FUNCTION_NAME_VARIABLE,
975 kLastKind = SLOPPY_FUNCTION_NAME_VARIABLE 974 kLastKind = SLOPPY_FUNCTION_NAME_VARIABLE
976 }; 975 };
977 976
978 inline bool IsDynamicVariableMode(VariableMode mode) { 977 inline bool IsDynamicVariableMode(VariableMode mode) {
979 return mode >= DYNAMIC && mode <= DYNAMIC_LOCAL; 978 return mode >= DYNAMIC && mode <= DYNAMIC_LOCAL;
980 } 979 }
981 980
982 981
983 inline bool IsDeclaredVariableMode(VariableMode mode) { 982 inline bool IsDeclaredVariableMode(VariableMode mode) {
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
1233 LIVE_EDIT_FRAME_DROPPED_IN_RETURN_CALL, 1232 LIVE_EDIT_FRAME_DROPPED_IN_RETURN_CALL,
1234 LIVE_EDIT_CURRENTLY_SET_MODE 1233 LIVE_EDIT_CURRENTLY_SET_MODE
1235 }; 1234 };
1236 1235
1237 } // namespace internal 1236 } // namespace internal
1238 } // namespace v8 1237 } // namespace v8
1239 1238
1240 namespace i = v8::internal; 1239 namespace i = v8::internal;
1241 1240
1242 #endif // V8_GLOBALS_H_ 1241 #endif // V8_GLOBALS_H_
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | test/cctest/interpreter/bytecode_expectations/Generators.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698