Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 2367463002: Fold DisplayItem creation into paintFilteredContent in SVGFilterPainter (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
Stephen Chennney, pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fold DisplayItem creation into paintFilteredContent in SVGFilterPainter Brings uses of any form of "filter bounds" closer together. Rename |filterRegion| and |boundaries| to |filterBounds|. BUG=109224 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/debded53b1df7614a159aff43e8041e0e25c9352 Cr-Commit-Position: refs/heads/master@{#420397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp View 3 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
fs
4 years, 2 months ago (2016-09-22 15:17:11 UTC) #7
Stephen Chennney
Definitely LGTM.
4 years, 2 months ago (2016-09-22 15:22:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367463002/1
4 years, 2 months ago (2016-09-22 17:54:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-22 18:07:56 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-22 18:10:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/debded53b1df7614a159aff43e8041e0e25c9352
Cr-Commit-Position: refs/heads/master@{#420397}

Powered by Google App Engine
This is Rietveld 408576698