Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2367423004: Place ellipsis correctly when its at the edge of a box (Closed)

Created:
4 years, 2 months ago by rhogan
Modified:
4 years, 2 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Place ellipsis correctly when it's at the edge of a mixed-direction box Place ellipsis correctly when we want to place it at the end of a box that has a text direction opposite to that of its containing flow. BUG=645938 Committed: https://crrev.com/9dbb17e178481b65239258b91cf42d6a73a5d990 Cr-Commit-Position: refs/heads/master@{#422212}

Patch Set 1 #

Patch Set 2 : bug 645938 #

Patch Set 3 : bug 645938 #

Messages

Total messages: 18 (13 generated)
rhogan
4 years, 2 months ago (2016-09-28 18:37:33 UTC) #9
eae
LGTM
4 years, 2 months ago (2016-09-28 19:36:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367423004/40001
4 years, 2 months ago (2016-09-30 18:11:28 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-30 20:44:40 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 20:48:13 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9dbb17e178481b65239258b91cf42d6a73a5d990
Cr-Commit-Position: refs/heads/master@{#422212}

Powered by Google App Engine
This is Rietveld 408576698