Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2367413002: [turbofan] Introduces the BitcastWordToTaggedSigned and BitcastTaggedToWord opcodes. (Closed)

Created:
4 years, 2 months ago by epertoso
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer, *Jarin
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduces the BitcastWordToTaggedSigned and BitcastTaggedToWord opcodes. They are nops, but will be used when verifying the machine graph. BUG= Committed: https://crrev.com/e25b264957b0f2734687700620533a5aad0e4859 Cr-Commit-Position: refs/heads/master@{#39758}

Patch Set 1 #

Patch Set 2 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -7 lines) Patch
M src/code-stub-assembler.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/code-assembler.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
epertoso
4 years, 2 months ago (2016-09-27 07:52:45 UTC) #4
Benedikt Meurer
LGTM.
4 years, 2 months ago (2016-09-27 09:55:30 UTC) #15
Jarin
lgtm
4 years, 2 months ago (2016-09-27 10:22:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367413002/20001
4 years, 2 months ago (2016-09-27 10:23:56 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 10:26:13 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 10:26:36 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e25b264957b0f2734687700620533a5aad0e4859
Cr-Commit-Position: refs/heads/master@{#39758}

Powered by Google App Engine
This is Rietveld 408576698