Snackbar for promoting Data Saver to existing users

chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPreferences.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.preferences.datareduction;
 
 import static org.chromium.third_party.android.datausagechart.ChartDataUsageView.DAYS_IN_CHART;
 
 import android.content.res.Resources;
 import android.os.Bundle;
 import android.preference.Preference;
 import android.preference.Preference.OnPreferenceChangeListener;
 import android.preference.PreferenceFragment;
 import android.text.format.DateUtils;
 import android.view.Menu;
 import android.view.MenuInflater;
 import android.view.MenuItem;
 
 import org.chromium.base.CommandLine;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.help.HelpAndFeedback;
 import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
 import org.chromium.chrome.browser.preferences.ChromeSwitchPreference;
 import org.chromium.chrome.browser.preferences.ManagedPreferenceDelegate;
 import org.chromium.chrome.browser.profiles.Profile;
+import org.chromium.chrome.browser.snackbar.DataReductionPromoSnackbarController;
 import org.chromium.third_party.android.datausagechart.NetworkStats;
 import org.chromium.third_party.android.datausagechart.NetworkStatsHistory;
 
 /**
  * Settings fragment that allows the user to configure Data Saver.
  */
 public class DataReductionPreferences extends PreferenceFragment {
 
     public static final String PREF_DATA_REDUCTION_SWITCH = "data_reduction_switch";
     private static final String PREF_DATA_REDUCTION_STATS = "data_reduction_stats";
 
     // This is the same as Chromium data_reduction_proxy::switches::kEnableDataReductionProxy.
     private static final String ENABLE_DATA_REDUCTION_PROXY = "enable-spdy-proxy-auth";
 
     private boolean mIsEnabled;
     private boolean mWasEnabledAtCreation;
+    // Whether the current activity is started from the snackbar promo.

[gone, 2016/10/13 01:03:11]

Maybe use single line javadoc syntax here so it shows up in IDEs?

/** Whether the current Activity is started from the snackbar promo. */

[megjablon, 2016/10/24 23:59:00]

Done.

+    private boolean mFromPromo;
 
     @Override
     public void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
 
         addPreferencesFromResource(R.xml.data_reduction_preferences);
         getActivity().setTitle(R.string.data_reduction_title);
         boolean isEnabled =
                 DataReductionProxySettings.getInstance().isDataReductionProxyEnabled();
         mIsEnabled = !isEnabled;
         mWasEnabledAtCreation = isEnabled;
         updatePreferences(isEnabled);
 
         setHasOptionsMenu(true);
+        Bundle extras = getActivity().getIntent().getExtras();

[gone, 2016/10/13 01:03:11]

Add another method to IntentUtils to handle this case; we keep getting Intents
from other apps that cause us to crash.  Look at how IntentUtils.safeGet* and
its ilk work.

[megjablon, 2016/10/24 23:59:00]

Using the existing safeGetBooleanExtra

+
+        if (extras != null) {
+            mFromPromo = extras.getBoolean(DataReductionPromoSnackbarController.FROM_PROMO);
+        }
     }
 
     @Override
     public void onDestroy() {
         super.onDestroy();
 
+        if (mFromPromo) {
+            if (mIsEnabled) {
+                DataReductionProxyUma.dataReductionProxyUIAction(
+                        DataReductionProxyUma.ACTION_SNACKBAR_LINK_CLICKED);
+                return;
+            }

[gone, 2016/10/13 01:03:11]

Could you integrate this into the conditional below?

if (mFromPromo) {
    statusChange = mIsEnabled
            ? DataReductionProxyUma.ACTION_SNACKBAR_LINK_CLICKED
            : DataReductionProxyUma.ACTION_SNACKBAR_LINK_CLICKED_DISABLED);
} else if (mWasEnabledAtCreation) {
    ...
} else {
    ...
}

[megjablon, 2016/10/24 23:59:00]

Done.

+            DataReductionProxyUma.dataReductionProxyUIAction(
+                    DataReductionProxyUma.ACTION_SNACKBAR_LINK_CLICKED_DISABLED);
+            return;
+        }
+
         int statusChange;
         if (mWasEnabledAtCreation) {
             statusChange = mIsEnabled
                     ? DataReductionProxyUma.ACTION_ON_TO_ON
                     : DataReductionProxyUma.ACTION_ON_TO_OFF;
         } else {
             statusChange = mIsEnabled
                     ? DataReductionProxyUma.ACTION_OFF_TO_ON
                     : DataReductionProxyUma.ACTION_OFF_TO_OFF;
         }
@@ skipping 111 matching lines @@
 
         getPreferenceScreen().addPreference(dataReductionSwitch);
 
         // Note: setting the switch state before the preference is added to the screen results in
         // some odd behavior where the switch state doesn't always match the internal enabled state
         // (e.g. the switch will say "On" when data reduction is really turned off), so
         // .setChecked() should be called after .addPreference()
         dataReductionSwitch.setChecked(isEnabled);
     }
 }