Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2367403003: [modules] Disallow return statement in module body. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Disallow return statement in module body. R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/1594b706a2d6d711dac49387ed3875c353f73997 Cr-Commit-Position: refs/heads/master@{#39740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/parsing/parser-base.h View 2 chunks +11 lines, -7 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 2 months ago (2016-09-26 18:55:12 UTC) #1
adamk
lgtm
4 years, 2 months ago (2016-09-26 19:02:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367403003/1
4 years, 2 months ago (2016-09-26 19:08:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 19:35:10 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 19:35:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1594b706a2d6d711dac49387ed3875c353f73997
Cr-Commit-Position: refs/heads/master@{#39740}

Powered by Google App Engine
This is Rietveld 408576698