[rAC, OSX] Add overlay shield for interstitials/waits.

chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_AUTOFILL_AUTOFILL_OVERLAY_CONTROLLER_H_
+#define CHROME_BROWSER_UI_COCOA_AUTOFILL_AUTOFILL_OVERLAY_CONTROLLER_H_
+
+#import <Cocoa/Cocoa.h>
+
+#include "base/mac/scoped_nsobject.h"
+#include "base/memory/scoped_ptr.h"
+#import "chrome/browser/ui/cocoa/autofill/autofill_layout.h"
+
+namespace autofill {
+  struct DialogOverlayState;

[sail, 2013/09/04 20:04:06]

Don't need to indent or add a "// namespace ..." comment.
Same below.

[groby-ooo-7-16, 2013/09/04 20:41:45]

Done.

+}  // namespace autofill
+
+namespace ui {
+  class Animation;
+  class MultiAnimation;
+}  // namespace ui
+
+class AnimationDelegateBridge;
+@class AutofillMessageStackView;
+
+// Protocol that allows Cocoa objects to act as a delegate for a ui::Animation.
+@protocol ChromiumAnimationDelegate

[sail, 2013/09/04 20:04:06]

How about just AnimationDelegate or AnimationDelegateProtocol?

[groby-ooo-7-16, 2013/09/04 20:41:45]

I'm fine with that - I just hope it doesn't clash at some point :)

On 2013/09/04 20:04:06, sail wrote:

+- (void)animationProgressed:(const ui::Animation*)animation;
+- (void)animationEnded:(const ui::Animation*)animation;
+@end
+
+
+@interface AutofillOverlayController :
+    NSViewController<ChromiumAnimationDelegate, AutofillLayout> {
+ @private
+  base::scoped_nsobject<NSBox> view_;  // The main view.

[sail, 2013/09/04 20:04:06]

Instead of keeping a separate reference to this, how about just adding a method
that just does a ObjCCastStrict<NSBox>([self view]).

[groby-ooo-7-16, 2013/09/04 20:41:45]

Done.

+  base::scoped_nsobject<NSView> childView_;  // Contains all UI elements.
+  base::scoped_nsobject<NSImageView> imageView_;
+  base::scoped_nsobject<AutofillMessageStackView> messageStackView_;
+
+  scoped_ptr<ui::MultiAnimation> fadeOutAnimation_;  // Animation rules.
+  scoped_ptr<AnimationDelegateBridge> animationDelegate_;
+}
+
+
+// Set the current dialog state.
+- (void)setState:(const autofill::DialogOverlayState&)state;
+
+// Start the animation sequence. At its end, the dialog will hide itself.
+- (void)beginFadeOut;
+
+// Get the preferred view height for a given width.
+- (int)getHeightForWidth:(int)width;

[sail, 2013/09/04 20:04:06]

how about heightForWidth:?

[groby-ooo-7-16, 2013/09/04 20:41:45]

Done.

+
+@end
+
+#endif  // CHROME_BROWSER_UI_COCOA_AUTOFILL_AUTOFILL_OVERLAY_CONTROLLER_H_
+