Migrating MediaSession messages to mojo

third_party/WebKit/Source/modules/mediasession/MojoMediaArtwork.h

Index: third_party/WebKit/Source/modules/mediasession/MojoMediaArtwork.h
diff --git a/third_party/WebKit/Source/modules/mediasession/MojoMediaArtwork.h b/third_party/WebKit/Source/modules/mediasession/MojoMediaArtwork.h
new file mode 100644
index 0000000000000000000000000000000000000000..c10064bf7ebacfcb12f5be4c8b163d9592305f13
--- /dev/null
+++ b/third_party/WebKit/Source/modules/mediasession/MojoMediaArtwork.h
@@ -0,0 +1,23 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MojoMediaArtwork_h
+#define MojoMediaArtwork_h
+
+#include "platform/weborigin/KURL.h"
+#include "public/platform/WebSize.h"
+#include "public/platform/WebString.h"
+#include "wtf/Vector.h"
+
+namespace blink {
+
+struct MojoMediaArtwork {

[Ken Rockot(use gerrit already), 2016/10/03 20:39:33]

You should either not use a typemap at all in Blink, or typemap to the existing
MediaMetadata and MediaArtwork types. I really don't think we want to introduce
new structure types just so we can typemap to them. The only reason to ever do
that would be if you needed some extra validation logic for the type, which it
seems you don't.

Typemapping to the existing types is a bit more involved, because the
StructTraits will have to define SetUpContext and TearDownContext in order to
build up some intermediate state for serialization (e.g. to create a KURL from
the src String), and you may need to provide some better way to construct the
MediaArtwork and MediaMetadata types for deserialization.

As already mentioned, it would also be reasonable to simply not typemap anything
here (yet) and work directly with the generated mojom types for now. It's fine
for content to typemap while Blink does not.

[Zhiqiang Zhang (Slow), 2016/10/03 21:00:20]

OK. Thanks for your explanation!
I was trying to mapping to blink::MediaMetadata and blink::MediaArtwork but
failed (because of v8 dependency) so I came up this solution. As you said it's
OK for content to typemap while Blink does not, I 'll revert this patch.

No need to PTAL for tsepez now.

+  KURL src;
+  WebString type;
+  Vector<WebSize> sizes;
+};
+
+}  // namespace blink
+
+#endif  // MojoMediaArtwork_h