Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: third_party/WebKit/public/platform/modules/mediasession/media_session.mojom

Issue 2367393002: Migrating MediaSession messages to mojo (Closed)
Patch Set: addressed Mounir's comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/modules/mediasession/media_session.mojom
diff --git a/third_party/WebKit/public/platform/modules/mediasession/media_session.mojom b/third_party/WebKit/public/platform/modules/mediasession/media_session.mojom
new file mode 100644
index 0000000000000000000000000000000000000000..2800e17b99596d91ebfa7570e44ccc528db4c229
--- /dev/null
+++ b/third_party/WebKit/public/platform/modules/mediasession/media_session.mojom
@@ -0,0 +1,26 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module blink.mojom;
+
+import "mojo/common/common_custom_types.mojom";
+import "ui/gfx/geometry/mojo/geometry.mojom";
+import "url/mojo/url.mojom";
+
+struct MediaMetadataIcon {
xhwang 2016/09/30 23:24:58 Please add comments to new interfaces. It's very h
Zhiqiang Zhang (Slow) 2016/10/03 14:31:13 Done.
+ url.mojom.Url src;
+ mojo.common.mojom.String16 type;
+ array<gfx.mojom.Size> sizes;
+};
+
+struct MediaMetadata {
+ mojo.common.mojom.String16 title;
+ mojo.common.mojom.String16 artist;
+ mojo.common.mojom.String16 album;
+ array<MediaMetadataIcon> artwork;
+};
+
+interface MediaSessionService {
xhwang 2016/09/30 23:24:58 nit: Do you really need the "Service" part? We use
Zhiqiang Zhang (Slow) 2016/10/03 14:31:13 Done. The sad thing is that we have too many class
+ SetMetadata(MediaMetadata? metadata);
+};

Powered by Google App Engine
This is Rietveld 408576698