Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2367383002: Don't track function-kind through FunctionState, always read from underlying scope (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't track function-kind through FunctionState, always read from underlying scope BUG= Committed: https://crrev.com/1c758066f14964a235288392e29e1a1a5aaebf82 Cr-Commit-Position: refs/heads/master@{#39763}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -37 lines) Patch
M src/parsing/parser.cc View 1 7 chunks +8 lines, -10 lines 0 comments Download
M src/parsing/parser-base.h View 1 12 chunks +15 lines, -21 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/parsing/preparser.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-09-26 13:25:18 UTC) #2
adamk
lgtm
4 years, 2 months ago (2016-09-26 17:47:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367383002/20001
4 years, 2 months ago (2016-09-27 11:13:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 11:41:04 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 11:41:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1c758066f14964a235288392e29e1a1a5aaebf82
Cr-Commit-Position: refs/heads/master@{#39763}

Powered by Google App Engine
This is Rietveld 408576698