Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: components/search_engines/template_url_service.h

Issue 2367373003: [Android] Allow setting recently visited search engines as default search engine (Closed)
Patch Set: Update based on Dan and Peter's comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url_service.h
diff --git a/components/search_engines/template_url_service.h b/components/search_engines/template_url_service.h
index 801ca6364295522dc093aff93e476256ab2f7a01..1b9e32b53dc4da4298b6fd4c065819b311132c9e 100644
--- a/components/search_engines/template_url_service.h
+++ b/components/search_engines/template_url_service.h
@@ -133,11 +133,15 @@ class TemplateURLService : public WebDataServiceConsumer,
const GURL& url,
TemplateURL** template_url_to_replace);
- // Returns whether |template_url| should be shown in the list of engines
- // most likely to be selected as a default engine. This is meant to highlight
- // the current default, as well as the other most likely choices of default
- // engine, separately from a full list of all TemplateURLs (which might be
- // very long).
+ // Retruns whether |template_url| should be shown in the list of engines
Peter Kasting 2016/11/29 03:32:19 Nit: Typo
ltian 2016/11/30 06:36:17 Done.
+ // most likely to be selected as a default engine. This includes all
+ // prepopulated engines and engines created by policy.
+ bool ShowInPrepopulatedList(const TemplateURL* template_url);
+
+ // Returns whether |template_url| is the current default or return true for
+ // ShowInPrepopulatedList(). This is meant to highlight the current default,
+ // as well as the other most likely choices of default engine, separately
+ // from a full list of all TemplateURLs (which might be very long).
Peter Kasting 2016/11/29 03:32:19 These comments are still confusingly overlapping.
ltian 2016/11/30 06:36:17 Done.
bool ShowInDefaultList(const TemplateURL* template_url);
// Adds to |matches| all TemplateURLs whose keywords begin with |prefix|,

Powered by Google App Engine
This is Rietveld 408576698