chrome/browser/search_engines/template_url_service_sync_unittest.cc - Issue 2367373003: [Android] Allow setting recently visited search engines as default search engine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/template_url_service_sync_unittest.cc

Issue 2367373003: [Android] Allow setting recently visited search engines as default search engine (Closed)

Patch Set: Update based on Dan's new comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/search_engines/template_url_service_android.cc ('K') | « chrome/browser/search_engines/template_url_service_android.cc ('k') | components/search_engines/template_url_service.h » ('j') | components/search_engines/template_url_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search_engines/template_url_service_sync_unittest.cc

diff --git a/chrome/browser/search_engines/template_url_service_sync_unittest.cc b/chrome/browser/search_engines/template_url_service_sync_unittest.cc

index e3af715c4367aa9397d14736792db71369bc46f1..44f38a376ba964391fecd41205f1771a7c45bf2d 100644

--- a/chrome/browser/search_engines/template_url_service_sync_unittest.cc

+++ b/chrome/browser/search_engines/template_url_service_sync_unittest.cc

@@ -1093,9 +1093,10 @@ TEST_F(TemplateURLServiceSyncTest, ProcessChangesWithLocalExtensions) {

// Create some sync changes that will conflict with the extension keywords.

syncer::SyncChangeList changes;

- changes.push_back(CreateTestSyncChange(syncer::SyncChange::ACTION_ADD,

- CreateTestTemplateURL(ASCIIToUTF16("keyword1"), "http://aaa.com",

- std::string(), 100, true)));

+ changes.push_back(CreateTestSyncChange(

+ syncer::SyncChange::ACTION_ADD,

+ CreateTestTemplateURL(ASCIIToUTF16("keyword1"), "http://aaa.com",

+ std::string(), 100, true, false, 0)));

changes.push_back(CreateTestSyncChange(syncer::SyncChange::ACTION_ADD,

CreateTestTemplateURL(ASCIIToUTF16("keyword2"), "http://bbb.com")));

model()->ProcessSyncChanges(FROM_HERE, changes);