Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2310)

Unified Diff: chrome/browser/search_engines/template_url_service_android.h

Issue 2367373003: [Android] Allow setting recently visited search engines as default search engine (Closed)
Patch Set: Update based on Ian's comments and fix bugs caused by test cases. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_android.h
diff --git a/chrome/browser/search_engines/template_url_service_android.h b/chrome/browser/search_engines/template_url_service_android.h
index af5f38c08a212727731e298448ae5df747711b74..c714dd32888fdfc3e441761cccbebae6db1a1c9f 100644
--- a/chrome/browser/search_engines/template_url_service_android.h
+++ b/chrome/browser/search_engines/template_url_service_android.h
@@ -27,7 +27,7 @@ class TemplateUrlServiceAndroid : public TemplateURLServiceObserver {
void SetUserSelectedDefaultSearchProvider(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
- jint selected_index);
+ const base::android::JavaParamRef<jstring>& jkeyword);
jint GetDefaultSearchProvider(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj);
@@ -71,13 +71,15 @@ class TemplateUrlServiceAndroid : public TemplateURLServiceObserver {
base::android::ScopedJavaLocalRef<jstring> GetSearchEngineUrlFromTemplateUrl(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
- jint index);
+ const base::android::JavaParamRef<jstring>& jkeyword);
static bool Register(JNIEnv* env);
private:
~TemplateUrlServiceAndroid() override;
+ bool IsInDefaultList(TemplateURL* url);
+
bool IsPrepopulatedTemplate(TemplateURL* url);
void OnTemplateURLServiceLoaded();
@@ -93,6 +95,8 @@ class TemplateUrlServiceAndroid : public TemplateURLServiceObserver {
std::unique_ptr<TemplateURLService::Subscription> template_url_subscription_;
DISALLOW_COPY_AND_ASSIGN(TemplateUrlServiceAndroid);
+
+ std::vector<TemplateURL*> template_url_list_;
Peter Kasting 2016/10/28 23:05:15 Nit: Goes above DISALLOW_COPY_AND_ASSIGN. Avoid u
ltian 2016/10/31 21:40:17 Done.
};
#endif // CHROME_BROWSER_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_ANDROID_H_

Powered by Google App Engine
This is Rietveld 408576698