chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java - Issue 2367373003: [Android] Allow setting recently visited search engines as default search engine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java

Issue 2367373003: [Android] Allow setting recently visited search engines as default search engine (Closed)

Patch Set: Update based on Ian's comments and fix bugs caused by test cases. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/res/layout/search_engine_recent_title.xml ('K') | « chrome/android/java/res/layout/search_engine_recent_title.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java

index ecf39a5b97eaad777b2f354bfd8c38b95ad508a6..4d0ee728bb75de5db673ac1d27e5fbdd3ca488d4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java

@@ -175,7 +175,7 @@ public final class PrefServiceBridge {

boolean allowed, Context context) {

TemplateUrlService templateUrlService = TemplateUrlService.getInstance();

String url = templateUrlService.getSearchEngineUrlFromTemplateUrl(

- templateUrlService.getDefaultSearchEngineIndex());

+ templateUrlService.getDefaultSearchEngineTemplateUrl().getKeyword());

if (allowed && !url.startsWith("https:")) return;

GeolocationInfo locationSettings = new GeolocationInfo(url, null, false);

ContentSetting locationPermission = locationSettings.getContentSetting();