Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Side by Side Diff: components/search_engines/template_url_service.h

Issue 2367373003: [Android] Allow setting recently visited search engines as default search engine (Closed)
Patch Set: Update based on Peter and Dan's comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_ 5 #ifndef COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_
6 #define COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_ 6 #define COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <list> 10 #include <list>
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 // keyword/url pair, or there is one but it can be replaced. If there is an 126 // keyword/url pair, or there is one but it can be replaced. If there is an
127 // existing keyword that can be replaced and template_url_to_replace is 127 // existing keyword that can be replaced and template_url_to_replace is
128 // non-NULL, template_url_to_replace is set to the keyword to replace. 128 // non-NULL, template_url_to_replace is set to the keyword to replace.
129 // 129 //
130 // |url| is the URL of the search query. This is used to prevent auto-adding 130 // |url| is the URL of the search query. This is used to prevent auto-adding
131 // a keyword for hosts already associated with a manually-edited keyword. 131 // a keyword for hosts already associated with a manually-edited keyword.
132 bool CanAddAutogeneratedKeyword(const base::string16& keyword, 132 bool CanAddAutogeneratedKeyword(const base::string16& keyword,
133 const GURL& url, 133 const GURL& url,
134 TemplateURL** template_url_to_replace); 134 TemplateURL** template_url_to_replace);
135 135
136 // Returns whether |template_url| should be shown in the list of engines 136 // Returns whether the engine is a "pre-existing" engine, either from the
137 // most likely to be selected as a default engine. This is meant to highlight 137 // prepopulate list or created by policy.
138 // the current default, as well as the other most likely choices of default 138 bool IsPrepopulatedOrCreatedByPolicy(const TemplateURL* template_url);
139 // engine, separately from a full list of all TemplateURLs (which might be 139
140 // very long). 140 // Returns whether |template_url| is the current default or return true for
141 // IsPrepopulatedOrCreatedByPolicy(). This is meant to highlight the current,
142 // default, as well as the other most likely choices of default engine,
143 // separately from a full list of all TemplateURLs (which might be very long).
Peter Kasting 2016/11/30 07:36:49 Nit: I still would revert this comment to the orig
141 bool ShowInDefaultList(const TemplateURL* template_url); 144 bool ShowInDefaultList(const TemplateURL* template_url);
142 145
143 // Adds to |matches| all TemplateURLs whose keywords begin with |prefix|, 146 // Adds to |matches| all TemplateURLs whose keywords begin with |prefix|,
144 // sorted shortest-keyword-first. If |supports_replacement_only| is true, only 147 // sorted shortest-keyword-first. If |supports_replacement_only| is true, only
145 // TemplateURLs that support replacement are returned. 148 // TemplateURLs that support replacement are returned.
146 void AddMatchingKeywords(const base::string16& prefix, 149 void AddMatchingKeywords(const base::string16& prefix,
147 bool supports_replacement_only, 150 bool supports_replacement_only,
148 TURLsAndMeaningfulLengths* matches); 151 TURLsAndMeaningfulLengths* matches);
149 152
150 // Adds to |matches| all TemplateURLs for search engines with the domain 153 // Adds to |matches| all TemplateURLs for search engines with the domain
(...skipping 670 matching lines...) Expand 10 before | Expand all | Expand 10 after
821 // Helper class to manage the default search engine. 824 // Helper class to manage the default search engine.
822 DefaultSearchManager default_search_manager_; 825 DefaultSearchManager default_search_manager_;
823 826
824 std::unique_ptr<GoogleURLTracker::Subscription> 827 std::unique_ptr<GoogleURLTracker::Subscription>
825 google_url_updated_subscription_; 828 google_url_updated_subscription_;
826 829
827 DISALLOW_COPY_AND_ASSIGN(TemplateURLService); 830 DISALLOW_COPY_AND_ASSIGN(TemplateURLService);
828 }; 831 };
829 832
830 #endif // COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_ 833 #endif // COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/search_engines/template_url_service_android.cc ('k') | components/search_engines/template_url_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698