Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | 6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
| 7 android:layout_width="match_parent" | 7 android:layout_width="match_parent" |
| 8 android:layout_height="wrap_content" | 8 android:layout_height="wrap_content" |
| 9 android:background="?android:attr/selectableItemBackground" | 9 android:background="?android:attr/selectableItemBackground" |
| 10 android:gravity="center_vertical" | 10 android:gravity="center_vertical" |
| 11 android:orientation="horizontal" | 11 android:orientation="horizontal" |
| 12 android:padding="6dp"> | 12 android:padding="6dp"> |
| 13 | 13 |
| 14 <android.widget.RadioButton | 14 <android.widget.RadioButton |
| 15 android:id="@+id/radiobutton" | 15 android:id="@+id/radiobutton" |
| 16 android:layout_width="wrap_content" | 16 android:layout_width="wrap_content" |
| 17 android:layout_height="wrap_content" | 17 android:layout_height="wrap_content" |
| 18 android:layout_marginEnd="21dp" | 18 android:layout_marginEnd="21dp" |
| 19 android:clickable="false" /> | 19 android:clickable="false" /> |
| 20 | 20 |
| 21 <LinearLayout | 21 <LinearLayout |
| 22 android:layout_width="0dp" | 22 android:layout_width="0dp" |
| 23 android:layout_height="wrap_content" | 23 android:layout_height="wrap_content" |
| 24 android:layout_weight="1" | 24 android:layout_weight="1" |
| 25 android:orientation="vertical"> | 25 android:orientation="vertical"> |
| 26 <TextView | 26 <TextView |
| 27 android:id="@+id/description" | 27 android:id="@+id/description" |
| 28 android:layout_width="wrap_content" | 28 android:layout_width="wrap_content" |
| 29 android:layout_height="wrap_content" | 29 android:layout_height="wrap_content" |
| 30 android:textSize="17sp" /> | 30 android:textSize="17sp" |
| 31 android:textColor="#000000" /> | |
| 32 <TextView | |
| 33 android:id="@+id/url" | |
| 34 android:layout_width="wrap_content" | |
| 35 android:layout_height="wrap_content" | |
| 36 android:textSize="16sp" | |
| 37 android:textColor="#646464" /> | |
|
gone
2016/11/01 21:30:29
@color/descriptive_text_color
ltian
2016/11/01 22:59:36
Done.
| |
| 31 <TextView | 38 <TextView |
| 32 android:id="@+id/link" | 39 android:id="@+id/link" |
|
gone
2016/11/01 21:30:29
These TextViews should be renamed: the "descriptio
ltian
2016/11/01 22:59:36
Done.
| |
| 33 android:layout_width="wrap_content" | 40 android:layout_width="wrap_content" |
| 34 android:layout_height="wrap_content" | 41 android:layout_height="wrap_content" |
| 35 android:layout_marginBottom="-12dp" | 42 android:layout_marginBottom="-12dp" |
| 36 android:layout_marginTop="-12dp" | 43 android:layout_marginTop="-12dp" |
| 37 android:gravity="center_vertical" | 44 android:gravity="center_vertical" |
| 38 android:minHeight="48dp" | 45 android:minHeight="48dp" |
| 39 android:paddingBottom="12dp" | 46 android:paddingBottom="12dp" |
| 40 android:paddingTop="12dp" /> | 47 android:paddingTop="12dp" /> |
|
gone
2016/11/01 21:30:29
This should have the color set, right?
android:te
ltian
2016/11/01 22:59:36
The color setting is coded in SearchEngineAdapter.
| |
| 41 </LinearLayout> | 48 </LinearLayout> |
| 42 | 49 |
| 43 </LinearLayout> | 50 </LinearLayout> |
| OLD | NEW |