chrome/android/java/res/layout/search_engine_recent_title.xml - Issue 2367373003: [Android] Allow setting recently visited search engines as default search engine

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/search_engine_recent_title.xml

Issue 2367373003: [Android] Allow setting recently visited search engines as default search engine (Closed)

Patch Set: Update based on Ian's comments and fix bugs caused by test cases. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/search_engine.xml ('K') | « chrome/android/java/res/layout/search_engine_layout.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file. -->

5 -->

6	5

7 <TextView xmlns:android="http://schemas.android.com/apk/res/android"	6 <TextView xmlns:android="http://schemas.android.com/apk/res/android"

8 android:drawablePadding="32dp"	7 android:text="@string/search_engine_recently_visited"

	8 android:layout_width="match_parent"

	9 android:layout_height="wrap_content"

	10 android:textColor="@color/light_active_color"

	11 android:textStyle="bold"

	12 android:textSize="15sp"
	gone 2016/10/31 22:31:28 Where'd you get the 15sp number from? 16sp is far Where'd you get the 15sp number from? 16sp is far more common in the code. Same for your other use of 15sp. ltian 2016/11/01 18:08:48 I might referred to a file that is not a common ca Show quoted text On 2016/10/31 22:31:28, dfalcantara (slow 10.24) wrote: > Where'd you get the 15sp number from? 16sp is far more common in the code. > Same for your other use of 15sp. I might referred to a file that is not a common case. Change it to 16sp.
9 android:gravity="center_vertical"	13 android:gravity="center_vertical"

10 android:id="@+id/navigation_item_label"	14 android:paddingBottom="16dp"
	Ian Wen 2016/10/28 22:17:39 Shouldn't you set clickable to be false here? Shouldn't you set clickable to be false here? ltian 2016/10/31 21:40:16 Done. Show quoted text On 2016/10/28 22:17:39, Ian Wen wrote: > Shouldn't you set clickable to be false here? Done.
11 android:layout_height="wrap_content"

12 android:layout_width="match_parent"

13 android:paddingStart="16dp"

14 android:paddingEnd="16dp"

15 android:paddingTop="16dp"	15 android:paddingTop="16dp"

16 android:paddingBottom="20dp"	16 android:paddingStart="12dp"

17 style="@style/NavigationTextStyle"/>	17 android:paddingEnd="6dp" />

OLD	NEW