Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2367333002: arc: Stop waiting for crash reporter on UI thread (Closed)

Created:
4 years, 2 months ago by hashimoto
Modified:
4 years, 2 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Stop waiting for crash reporter on UI thread We shouldn't block the UI thread waiting for crash_reporter which performs disk IO. BUG=None Committed: https://crrev.com/29688ee2a715d78d1f90e30356e32f3542142c4e Cr-Commit-Position: refs/heads/master@{#421141}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Everything on the blocking task runner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -24 lines) Patch
M components/arc/arc_service_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/arc/crash_collector/arc_crash_collector_bridge.h View 3 chunks +9 lines, -1 line 0 comments Download
M components/arc/crash_collector/arc_crash_collector_bridge.cc View 1 2 chunks +39 lines, -22 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
hashimoto
4 years, 2 months ago (2016-09-26 10:01:37 UTC) #4
hidehiko
lgtm. https://codereview.chromium.org/2367333002/diff/1/components/arc/crash_collector/arc_crash_collector_bridge.cc File components/arc/crash_collector/arc_crash_collector_bridge.cc (right): https://codereview.chromium.org/2367333002/diff/1/components/arc/crash_collector/arc_crash_collector_bridge.cc#newcode70 components/arc/crash_collector/arc_crash_collector_bridge.cc:70: blocking_task_runner_->PostTask(FROM_HERE, Optional: How about moving everything, incl. LaunchProcess, ...
4 years, 2 months ago (2016-09-26 14:17:22 UTC) #7
hashimoto
https://codereview.chromium.org/2367333002/diff/1/components/arc/crash_collector/arc_crash_collector_bridge.cc File components/arc/crash_collector/arc_crash_collector_bridge.cc (right): https://codereview.chromium.org/2367333002/diff/1/components/arc/crash_collector/arc_crash_collector_bridge.cc#newcode70 components/arc/crash_collector/arc_crash_collector_bridge.cc:70: blocking_task_runner_->PostTask(FROM_HERE, On 2016/09/26 14:17:22, hidehiko wrote: > Optional: How ...
4 years, 2 months ago (2016-09-27 06:48:26 UTC) #12
hidehiko
lgtm
4 years, 2 months ago (2016-09-27 06:49:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367333002/60001
4 years, 2 months ago (2016-09-27 07:46:23 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 2 months ago (2016-09-27 07:51:26 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 07:53:51 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29688ee2a715d78d1f90e30356e32f3542142c4e
Cr-Commit-Position: refs/heads/master@{#421141}

Powered by Google App Engine
This is Rietveld 408576698