Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 236733006: Allow the user to tap the selected editable again after rotation to trigger another zoom/center anim (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: PTAL modified according to review comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 3322 matching lines...) Expand 10 before | Expand all | Expand 10 after
3333 } 3333 }
3334 3334
3335 void RenderViewImpl::OnMediaPlayerActionAt(const gfx::Point& location, 3335 void RenderViewImpl::OnMediaPlayerActionAt(const gfx::Point& location,
3336 const WebMediaPlayerAction& action) { 3336 const WebMediaPlayerAction& action) {
3337 if (webview()) 3337 if (webview())
3338 webview()->performMediaPlayerAction(action, location); 3338 webview()->performMediaPlayerAction(action, location);
3339 } 3339 }
3340 3340
3341 void RenderViewImpl::OnOrientationChangeEvent(int orientation) { 3341 void RenderViewImpl::OnOrientationChangeEvent(int orientation) {
3342 // Screen has rotated. 0 = default (portrait), 90 = one turn right, and so on. 3342 // Screen has rotated. 0 = default (portrait), 90 = one turn right, and so on.
3343 has_scrolled_focused_editable_node_into_rect_ = false;
3343 FOR_EACH_OBSERVER(RenderViewObserver, 3344 FOR_EACH_OBSERVER(RenderViewObserver,
3344 observers_, 3345 observers_,
3345 OrientationChangeEvent(orientation)); 3346 OrientationChangeEvent(orientation));
3346 webview()->mainFrame()->sendOrientationChangeEvent(orientation); 3347 webview()->mainFrame()->sendOrientationChangeEvent(orientation);
3347 } 3348 }
3348 3349
3349 void RenderViewImpl::OnPluginActionAt(const gfx::Point& location, 3350 void RenderViewImpl::OnPluginActionAt(const gfx::Point& location,
3350 const WebPluginAction& action) { 3351 const WebPluginAction& action) {
3351 if (webview()) 3352 if (webview())
3352 webview()->performPluginAction(action, location); 3353 webview()->performPluginAction(action, location);
(...skipping 1165 matching lines...) Expand 10 before | Expand all | Expand 10 after
4518 std::vector<gfx::Size> sizes; 4519 std::vector<gfx::Size> sizes;
4519 ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes); 4520 ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
4520 if (!url.isEmpty()) 4521 if (!url.isEmpty())
4521 urls.push_back( 4522 urls.push_back(
4522 FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes)); 4523 FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
4523 } 4524 }
4524 SendUpdateFaviconURL(urls); 4525 SendUpdateFaviconURL(urls);
4525 } 4526 }
4526 4527
4527 } // namespace content 4528 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698