Allow the user to tap the selected editable again after rotation to trigger another zoom/center anim

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 647 matching lines @@
       frames_in_progress_(0),
       target_url_status_(TARGET_NONE),
 #if defined(OS_ANDROID)
       top_controls_constraints_(cc::BOTH),
 #endif
       cached_is_main_frame_pinned_to_left_(false),
       cached_is_main_frame_pinned_to_right_(false),
       cached_has_main_frame_horizontal_scrollbar_(false),
       cached_has_main_frame_vertical_scrollbar_(false),
       has_scrolled_focused_editable_node_into_rect_(false),
+      is_orientation_changed_(false),
       notification_provider_(NULL),
       push_messaging_dispatcher_(NULL),
       geolocation_dispatcher_(NULL),
       input_tag_speech_dispatcher_(NULL),
       speech_recognition_dispatcher_(NULL),
       media_stream_dispatcher_(NULL),
       browser_plugin_manager_(NULL),
       media_stream_client_(NULL),
       web_user_media_client_(NULL),
       midi_dispatcher_(NULL),
@@ skipping 577 matching lines @@
     return;
 
   Send(new ViewHostMsg_MoveCaret_ACK(routing_id_));
 
   webview()->focusedFrame()->moveCaretSelection(point);
 }
 
 void RenderViewImpl::OnScrollFocusedEditableNodeIntoRect(
     const gfx::Rect& rect) {
   if (has_scrolled_focused_editable_node_into_rect_ &&
-      rect == rect_for_scrolled_focused_editable_node_) {
+      rect == rect_for_scrolled_focused_editable_node_ &&
+      !is_orientation_changed_) {
     return;
   }
 
   blink::WebElement element = GetFocusedElement();
   if (!element.isNull() && IsEditableNode(element)) {
     rect_for_scrolled_focused_editable_node_ = rect;
     has_scrolled_focused_editable_node_into_rect_ = true;
+    is_orientation_changed_ = false;
     webview()->scrollFocusedNodeIntoRect(rect);
   }
 }
 
 void RenderViewImpl::OnSetEditCommandsForNextKeyEvent(
     const EditCommands& edit_commands) {
   edit_commands_ = edit_commands;
 }
 
 void RenderViewImpl::OnSetName(const std::string& name) {
@@ skipping 2057 matching lines @@
 }
 
 void RenderViewImpl::OnMediaPlayerActionAt(const gfx::Point& location,
                                            const WebMediaPlayerAction& action) {
   if (webview())
     webview()->performMediaPlayerAction(action, location);
 }
 
 void RenderViewImpl::OnOrientationChangeEvent(int orientation) {
   // Screen has rotated. 0 = default (portrait), 90 = one turn right, and so on.
+  is_orientation_changed_ = true;

[jdduke (slow), 2014/04/15 14:36:00]

Why not just set |has_scrolled_focused_editable_node_into_rect_| as false here?

[jdduke (slow), 2014/04/16 14:51:40]

Until we have a solution to the multiple resize problem (crbug.com/363182),
let's go ahead and just set |has_scrolled_focused_editable_node_into_rect_ =
false| here.  Then at least, if the user taps the editable again, it will scroll
and zoom the editable into view properly.  The rest of the changes won't be
necessary.

   FOR_EACH_OBSERVER(RenderViewObserver,
                     observers_,
                     OrientationChangeEvent(orientation));
   webview()->mainFrame()->sendOrientationChangeEvent(orientation);
 }
 
 void RenderViewImpl::OnPluginActionAt(const gfx::Point& location,
                                       const WebPluginAction& action) {
   if (webview())
     webview()->performPluginAction(action, location);
@@ skipping 1168 matching lines @@
     std::vector<gfx::Size> sizes(icon_urls[i].sizes().size());
     ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
     if (!url.isEmpty())
       urls.push_back(
           FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content