Issue 236733005: Remove redundant crash tests using Selection.modify("-webkit-visual-word").

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 236733005: Remove redundant crash tests using Selection.modify("-webkit-visual-word"). (Closed)

Created:
6 years, 8 months ago by yoichio

Modified:
6 years, 8 months ago

Reviewers:
Yuta Kitamura, yosin_UTC9

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Remove redundant crash tests using Selection.modify("-webkit-visual-word"). We removed experimental flag -webkit-visual-word 2 years ago: http://src.chromium.org/viewvc/blink/trunk/Source/core/page/DOMSelection.cpp?r1=89440&r2=102252 Selection.modify("-webkit-visual-word") does nothing. However, there are still tests using the flag. They confirm that scripts don't crash when they call Selection.modify("-webkit-visual-word"). It doesn't make sense. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171453

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -56 lines)			Patch
D	LayoutTests/editing/selection/move-by-word-visually-crash-test-textarea.html	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	LayoutTests/editing/selection/move-by-word-visually-crash-test-textarea-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	LayoutTests/editing/selection/move-by-word-visually-null-box.html	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	LayoutTests/editing/selection/move-by-word-visually-null-box-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/236733005/1

6 years, 8 months ago (2014-04-14 10:39:45 UTC) #4

Message was sent while issue was closed.

Change committed as 171453