Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 236733003: Remove the need for <polymer-selector> in the PDF plugin. (Closed)

Created:
6 years, 8 months ago by raymes
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Remove the need for <polymer-selector> in the PDF plugin. <polymer-selector> is no longer necessary as button selection state is kept in the viewport. This also removes the now unused polymer-selector libraries from third_party/. BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263849

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1948 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/pdf/includes.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/index.html View 2 chunks +16 lines, -19 lines 0 comments Download
D third_party/polymer/PRESUBMIT.py View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
M third_party/polymer/README.chromium View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/polymer/bower.json View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/polymer/polymer-selection/.bower.json View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/polymer/polymer-selection/AUTHORS View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/polymer/polymer-selection/CONTRIBUTING.md View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/polymer-selection/LICENSE View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/polymer/polymer-selection/PATENTS View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/polymer/polymer-selection/bower.json View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/polymer/polymer-selection/index.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/polymer/polymer-selection/polymer-selection.html View 1 chunk +0 lines, -153 lines 0 comments Download
D third_party/polymer/polymer-selection/test/html/polymer-selection.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/polymer/polymer-selection/test/html/polymer-selection-multi.html View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/polymer/polymer-selection/test/js/polymer-selection.js View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/polymer/polymer-selection/test/runner.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/polymer/polymer-selector/.bower.json View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/polymer/polymer-selector/AUTHORS View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/polymer/polymer-selector/CONTRIBUTING.md View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/polymer-selector/LICENSE View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/polymer/polymer-selector/PATENTS View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/polymer/polymer-selector/README.md View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/polymer/polymer-selector/bower.json View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/polymer/polymer-selector/index.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/polymer/polymer-selector/polymer-selector.html View 1 chunk +0 lines, -371 lines 0 comments Download
D third_party/polymer/polymer-selector/test/html/polymer-selector-activate-event.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/polymer/polymer-selector/test/html/polymer-selector-basic.html View 1 chunk +0 lines, -96 lines 0 comments Download
D third_party/polymer/polymer-selector/test/html/polymer-selector-multi.html View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/polymer/polymer-selector/test/js/polymer-selector.js View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/polymer/polymer-selector/test/runner.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/polymer/vulcanized/polymer-elements.html View 1 chunk +0 lines, -175 lines 0 comments Download
D third_party/polymer/vulcanized/polymer-elements.js View 1 chunk +0 lines, -435 lines 0 comments Download
D third_party/polymer/vulcanized/polymer-elements.in.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/polymer/vulcanized/vulcanize.py View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
raymes
arv@ for chrome/browser/resources/* rsadam@ for third_party/
6 years, 8 months ago (2014-04-14 07:21:26 UTC) #1
rsadam
lgtm
6 years, 8 months ago (2014-04-14 13:52:45 UTC) #2
arv (Not doing code reviews)
LGTM
6 years, 8 months ago (2014-04-14 14:51:15 UTC) #3
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 8 months ago (2014-04-15 03:51:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/236733003/20001
6 years, 8 months ago (2014-04-15 03:52:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-15 04:37:11 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61473
6 years, 8 months ago (2014-04-15 04:37:11 UTC) #7
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 8 months ago (2014-04-15 05:54:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/236733003/40001
6 years, 8 months ago (2014-04-15 05:56:29 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 14:42:21 UTC) #10
Message was sent while issue was closed.
Change committed as 263849

Powered by Google App Engine
This is Rietveld 408576698