Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2367263002: Enable goma on pdfium buildbots by default. (Closed)

Created:
4 years, 2 months ago by tikuta
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Enable goma on pdfium buildbots by default. This CL is reland of https://codereview.chromium.org/2297663007/ fix: set goma_dir in 'gn gen' step. BUG=643139 Committed: https://chromium.googlesource.com/chromium/tools/build/+/df6070deda2483b959814f4af4ed12bc56a708ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4453 lines, -72 lines) Patch
M scripts/slave/recipes/pdfium.py View 5 chunks +14 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/android.json View 2 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/drm_win_xfa.json View 4 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_asan.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_no_v8.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_skia.json View 2 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_asan.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/linux_xfa_rel.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_no_v8.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_skia.json View 2 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_xfa.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/mac_xfa_rel.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/try-linux_xfa_asan.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_no_v8.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_skia.json View 2 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_32.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_clang.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_clang_32.json View 3 chunks +193 lines, -3 lines 0 comments Download
M scripts/slave/recipes/pdfium.expected/win_xfa_rel.json View 3 chunks +193 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tikuta
Please review again.
4 years, 2 months ago (2016-09-26 03:04:07 UTC) #2
Paweł Hajdan Jr.
LGTM
4 years, 2 months ago (2016-09-26 21:42:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367263002/1
4 years, 2 months ago (2016-09-27 01:56:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/df6070deda2483b959814f4af4ed12bc56a708ac
4 years, 2 months ago (2016-09-27 02:00:25 UTC) #7
Lei Zhang
Windows bots are unhappy again on https://build.chromium.org/p/client.pdfium/console e.g. https://build.chromium.org/p/client.pdfium/builders/windows/builds/1666
4 years, 2 months ago (2016-09-27 02:40:53 UTC) #8
tikuta
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2377553002/ by tikuta@chromium.org. ...
4 years, 2 months ago (2016-09-27 02:42:15 UTC) #9
Dirk Pranke
4 years, 2 months ago (2016-09-27 18:13:23 UTC) #10
Message was sent while issue was closed. 
rs- lgtm :).

Powered by Google App Engine
This is Rietveld 408576698