Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2367253006: Check for touch event queue size before popping. (Closed)

Created:
4 years, 2 months ago by dtapuska
Modified:
4 years, 2 months ago
Reviewers:
mustaq
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for touch event queue size before popping. Don't allow the browser process to crash if for some reason the renderer process sends too many ack events. BUG=598483 Committed: https://crrev.com/9d7cdbdbc717c68e7ad51b43d282599ebb6af6c3 Cr-Commit-Position: refs/heads/master@{#421330}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change not reached line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/renderer_host/input/touch_event_queue.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
dtapuska
4 years, 2 months ago (2016-09-27 19:42:45 UTC) #4
mustaq
lgtm https://codereview.chromium.org/2367253006/diff/1/content/browser/renderer_host/input/touch_event_queue.cc File content/browser/renderer_host/input/touch_event_queue.cc (right): https://codereview.chromium.org/2367253006/diff/1/content/browser/renderer_host/input/touch_event_queue.cc#newcode770 content/browser/renderer_host/input/touch_event_queue.cc:770: NOTREACHED() << "Incorrect number of acks"; Nit: "Too ...
4 years, 2 months ago (2016-09-27 19:53:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367253006/20001
4 years, 2 months ago (2016-09-27 19:56:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 20:54:44 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 21:01:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d7cdbdbc717c68e7ad51b43d282599ebb6af6c3
Cr-Commit-Position: refs/heads/master@{#421330}

Powered by Google App Engine
This is Rietveld 408576698