Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/LayoutTests/fragmentation/repeating-thead-no-room-for-content-row-on-first-page.html

Issue 2367243002: Don't repeat header groups when one row of content doesn't fit on the first page (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fragmentation/repeating-thead-no-room-for-content-row-on-first-page.html
diff --git a/third_party/WebKit/LayoutTests/fragmentation/single-line-cells.html b/third_party/WebKit/LayoutTests/fragmentation/repeating-thead-no-room-for-content-row-on-first-page.html
similarity index 60%
copy from third_party/WebKit/LayoutTests/fragmentation/single-line-cells.html
copy to third_party/WebKit/LayoutTests/fragmentation/repeating-thead-no-room-for-content-row-on-first-page.html
index 911c680fb60a6ab940dbc0f339071d41603a7785..4fc9c30b5dd6cd80e9bc659a3afc07023f609bb1 100644
--- a/third_party/WebKit/LayoutTests/fragmentation/single-line-cells.html
+++ b/third_party/WebKit/LayoutTests/fragmentation/repeating-thead-no-room-for-content-row-on-first-page.html
@@ -3,45 +3,40 @@
table {
border-collapse: collapse;
}
-td {
- background-color: #ddd;
- border: 1px solid black;
-}
-tr {
+thead, tr {
break-inside: avoid;
}
</style>
-<p>crbug.com/99124: Table rows shouldn't straddle page boundaries.</p>
-<div style="-webkit-columns:3; line-height: 20px; column-fill: auto; height:190px; background-color: yellow;">
- <table>
- <tr><td>Te</td><td>xt</td></tr>
- <tr><td>Te</td><td>xt</td></tr>
- <tr><td>Te</td><td>xt</td></tr>
- <tr><td>Te</td><td>xt</td></tr>
- <tr><td>Te</td><td>xt</td></tr>
+<p>crbug.com/621258: Drop the repeated header if there isn't room for at least one content row on the page.</p>
+<div style="-webkit-columns:3; line-height: 20px; column-fill: auto; height:190px;">
+ <table id="top">
+ <thead id="top-thead">
+ <tr>
+ <th><div style="height: 180px;">Col 1</div></th>
+ </tr>
+ </thead>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
- <tr><td class="td" data-total-y=191>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
+ <tr><td class="cell" data-total-y=380>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
- <tr><td class="td" data-total-y=381>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
+ <tr><td class="cell" data-total-y=570>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
</table>
</div>
<div id="console"></div>
<script src="../resources/check-layout.js"></script>
<script>
- checkLayout(".td", document.getElementById("console"));
+checkLayout(".cell", document.getElementById("console"));
</script>
-

Powered by Google App Engine
This is Rietveld 408576698