Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: third_party/WebKit/LayoutTests/fragmentation/repeating-thead-exceeds-page-size.html

Issue 2367243002: Don't repeat header groups when one row of content doesn't fit on the first page (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fragmentation/repeating-thead-exceeds-page-size-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fragmentation/repeating-thead-exceeds-page-size.html
diff --git a/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead.html b/third_party/WebKit/LayoutTests/fragmentation/repeating-thead-exceeds-page-size.html
similarity index 61%
copy from third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead.html
copy to third_party/WebKit/LayoutTests/fragmentation/repeating-thead-exceeds-page-size.html
index fd02654f2be72865889941b48dc305eeb39e36aa..5a185b29a7861c3ca702699975c4d2b6b91aeb33 100644
--- a/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead.html
+++ b/third_party/WebKit/LayoutTests/fragmentation/repeating-thead-exceeds-page-size.html
@@ -4,23 +4,19 @@ table {
border-collapse: collapse;
}
td, th {
- background-color: #ddd;
- border: 1px solid black;
}
thead, tr {
break-inside: avoid;
}
</style>
-<p>crbug.com/24826: A table header group repeats on each page.</p>
-<div style="-webkit-columns:3; line-height: 20px; column-fill: auto; height:190px; background-color: yellow;">
- <table>
- <thead>
+<p>crbug.com/621258: Drop the repeated header if there isn't room for at least one content row on the page.</p>
+<div style="-webkit-columns:3; line-height: 20px; column-fill: auto; height:190px;">
+ <table id="top">
+ <thead id="top-thead">
<tr>
- <th>Col 1</th>
- <th>Col 2</th>
+ <th><div style="height: 195px;">Col 1</div></th>
</tr>
</thead>
- <tbody>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
@@ -29,6 +25,7 @@ thead, tr {
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
+ <tr><td class="cell" data-total-y=380>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
@@ -36,15 +33,13 @@ thead, tr {
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
+ <tr><td class="cell" data-total-y=570>Te</td><td>xt</td></tr>
<tr><td>Te</td><td>xt</td></tr>
- <tr><td>Te</td><td>xt</td></tr>
- <tr><td>Te</td><td>xt</td></tr>
- <tr><td>Te</td><td>xt</td></tr>
- <tr><td>Te</td><td>xt</td></tr>
- <tr><td>Te</td><td>xt</td></tr>
- <tr><td>Te</td><td>xt</td></tr>
- <tr><td>Te</td><td>xt</td></tr>
- </tbody>
</table>
</div>
+<div id="console"></div>
+<script src="../resources/check-layout.js"></script>
+<script>
+checkLayout(".cell", document.getElementById("console"));
+</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fragmentation/repeating-thead-exceeds-page-size-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698