Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 236723004: Update CheckBothSmi, CheckInteger32ValidSmiValue, CheckUInteger32ValidSmiValue, SmiAddConstant, Smi… (Closed)

Created:
6 years, 8 months ago by haitao.feng
Modified:
6 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Update CheckBothSmi, CheckInteger32ValidSmiValue, CheckUInteger32ValidSmiValue, SmiAddConstant, SmiNot, AddSmiField and Test to support x32 port. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -14 lines) Patch
M src/x64/macro-assembler-x64.cc View 6 chunks +56 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
PTAL.
6 years, 8 months ago (2014-04-14 12:56:52 UTC) #1
Toon Verwaest
lgtm
6 years, 8 months ago (2014-04-17 09:09:05 UTC) #2
haitao.feng
6 years, 8 months ago (2014-04-17 23:17:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20862 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698