Issue 236723003: Allow the PDF page indicator to accept a list of page labels

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 236723003: Allow the PDF page indicator to accept a list of page labels (Closed)

Created:
6 years, 8 months ago by raymes

Modified:
6 years, 8 months ago

Reviewers:
koz (OOO until 15th September)

CC:
ganetsky1, Jelte, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/html-office-public.git@master

Visibility:
Public.

More Reviews

Description

Allow the PDF page indicator to accept a list of page labels This allows the page indicator polymer element to accept a list of page labels which get displayed. This is useful for print preview where page labels may not be sequential indices. BUG=303491 R=koz@chromium.org Committed: eeff976

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	elements/viewer-page-indicator/viewer-page-indicator.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	elements/viewer-page-indicator/viewer-page-indicator.js	View		2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

raymes

6 years, 8 months ago (2014-04-15 01:30:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as reeff976 (presubmit successful).

Expand Messages | Collapse Messages