Issue 23672059: HandleScopeImplementer::entered_contexts_ should not store handles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23672059: HandleScopeImplementer::entered_contexts_ should not store handles (Closed)

Created:
7 years, 3 months ago by dcarney

Modified:
7 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

HandleScopeImplementer::entered_contexts_ should not store handles R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16917

Patch Set 1 : #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -14 lines)			Patch
	M	src/api.h	View		3 chunks	+11 lines, -11 lines	0 comments	Download
	M	src/api.cc	View		1 chunk	+5 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM if one comment is addressed. https://codereview.chromium.org/23672059/diff/2001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/23672059/diff/2001/src/api.cc#newcode7432 src/api.cc:7432: Object** start = ...

7 years, 3 months ago (2013-09-24 11:30:46 UTC) #2

dcarney

7 years, 3 months ago (2013-09-24 11:40:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16917 (presubmit successful).

Expand Messages | Collapse Messages