Issue 23672055: [Android] Inflate Select Action Bar from XML.

Issue 23672055: [Android] Inflate Select Action Bar from XML. (Closed)

Created:
7 years, 3 months ago by benm (inactive)

Modified:
7 years, 2 months ago

Reviewers:
joth, newt (away)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Inflate Select Action Bar from XML. This gives us most flexibility in applying styles for content/ embedders. No change in behavior. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225480

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -95 lines)			Patch
A	content/public/android/java/res/menu/select_action_menu.xml	View	1 2	1 chunk	+50 lines, -0 lines	0 comments	Download
M	content/public/android/java/res/values-v17/styles.xml	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/public/android/java/res/values/attrs.xml	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/public/android/java/resource_map/org/chromium/content/R.java	View	1 2	4 chunks	+13 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java	View	1	3 chunks	+29 lines, -89 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

benm (inactive)

PTAL Newton - this is the proper fix for the styling on the action bar ...

7 years, 3 months ago (2013-09-23 21:03:32 UTC) #1

newt (away)

lgtm thanks, Ben! this looks much better :) https://codereview.chromium.org/23672055/diff/5001/content/public/android/java/res/menu/select_action_menu.xml File content/public/android/java/res/menu/select_action_menu.xml (right): https://codereview.chromium.org/23672055/diff/5001/content/public/android/java/res/menu/select_action_menu.xml#newcode10 content/public/android/java/res/menu/select_action_menu.xml:10: <item ...

7 years, 2 months ago (2013-09-25 18:18:52 UTC) #2

benm (inactive)

Thanks newt! https://codereview.chromium.org/23672055/diff/5001/content/public/android/java/res/menu/select_action_menu.xml File content/public/android/java/res/menu/select_action_menu.xml (right): https://codereview.chromium.org/23672055/diff/5001/content/public/android/java/res/menu/select_action_menu.xml#newcode10 content/public/android/java/res/menu/select_action_menu.xml:10: <item android:id="@+id/select_action_menu_select_all" On 2013/09/25 18:18:53, newt wrote: ...

7 years, 2 months ago (2013-09-25 19:31:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benm@chromium.org/23672055/13001

7 years, 2 months ago (2013-09-26 11:30:01 UTC) #6

Message was sent while issue was closed.

Change committed as 225480

Expand Messages | Collapse Messages