Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 23672045: Mark morphology test as expected-to-fail for poppler. (Closed)

Created:
7 years, 3 months ago by Stephen White
Modified:
7 years, 3 months ago
Reviewers:
edisonn, epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Mark morphology test as ignore-failure for poppler. R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=11359

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix bug IDs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 2 chunks +3 lines, -2 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 1 2 chunks +3 lines, -2 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release/expected-results.json View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Stephen White
PTAL. I'm not sure if this is the right thing to do, but it might ...
7 years, 3 months ago (2013-09-18 19:00:20 UTC) #1
epoger
https://codereview.chromium.org/23672045/diff/1/expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json File expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json (right): https://codereview.chromium.org/23672045/diff/1/expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json#newcode10533 expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json:10533: 1578 For all these ignored tests, please replace the ...
7 years, 3 months ago (2013-09-18 19:05:32 UTC) #2
Stephen White
https://codereview.chromium.org/23672045/diff/1/expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json File expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json (right): https://codereview.chromium.org/23672045/diff/1/expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json#newcode10533 expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json:10533: 1578 On 2013/09/18 19:05:32, epoger wrote: > For all ...
7 years, 3 months ago (2013-09-18 19:08:52 UTC) #3
epoger
lgtm
7 years, 3 months ago (2013-09-18 19:14:55 UTC) #4
Stephen White
7 years, 3 months ago (2013-09-18 19:21:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r11359 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698