Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23672027: Rename OS(WINDOWS) to OS(WIN) (Closed)

Created:
7 years, 3 months ago by lgombos
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), jamesr, caseq+blink_chromium.org, Nate Chapin, dsinclair, yurys+blink_chromium.org, abarth-chromium, danakj, marja+watch_chromium.org, dglazkov+blink, Rik, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, groby+blinkspell_chromium.org, Stephen Chennney, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename OS(WINDOWS) to OS(WIN) to be consistent with the rest of chromium and build_config.h. BUG=286645 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -144 lines) Patch
M Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/config.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElementWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/AutoscrollController.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/AutoscrollController.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/page/DragController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M Source/core/page/Page.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Settings.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/Pasteboard.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/audio/DenormalDisabler.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/chromium/ClipboardChromium.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/chromium/ClipboardChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/chromium/ClipboardUtilitiesChromium.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/chromium/ClipboardUtilitiesChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/chromium/KeyboardCodes.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/chromium/PlatformKeyboardEventChromium.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/platform/graphics/FontCache.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/graphics/FontCache.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/platform/graphics/FontCustomPlatformData.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/platform/graphics/FontPlatformData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/GraphicsContext3D.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/skia/FontCacheSkia.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/skia/SimpleFontDataSkia.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/sql/SQLiteDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/text/LineEnding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumDefault.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/EditorClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/wtf/Assertions.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Assertions.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/wtf/Atomics.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/ByteOrder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/DateMath.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/wtf/FastMalloc.cpp View 18 chunks +20 lines, -20 lines 0 comments Download
M Source/wtf/GregorianDateTime.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/NumberOfCores.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/PageAllocator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/ProcessID.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/TCSystemAlloc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/ThreadSpecific.h View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/wtf/ThreadSpecificWin.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/ThreadingPrimitives.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/wtf/ThreadingWin.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/wtf/tests/IntegerToStringConversion.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lgombos
It saves about 0.5 kB source code space..
7 years, 3 months ago (2013-09-07 23:58:20 UTC) #1
abarth-chromium
rs=me LGTM
7 years, 3 months ago (2013-09-08 05:11:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23672027/1
7 years, 3 months ago (2013-09-08 16:11:05 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-08 22:51:57 UTC) #4
Message was sent while issue was closed. 
Change committed as 157418

Powered by Google App Engine
This is Rietveld 408576698