Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 23672004: Insert allocation memento clear instructions after the dominating allocate instruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3305 matching lines...) Expand 10 before | Expand all | Expand 10 after
3316 Representation::None(), 3316 Representation::None(),
3317 dominator_allocate); 3317 dominator_allocate);
3318 dominator_allocate->UpdateSize(new_dominator_size_constant); 3318 dominator_allocate->UpdateSize(new_dominator_size_constant);
3319 3319
3320 #ifdef VERIFY_HEAP 3320 #ifdef VERIFY_HEAP
3321 if (FLAG_verify_heap && dominator_allocate->IsNewSpaceAllocation()) { 3321 if (FLAG_verify_heap && dominator_allocate->IsNewSpaceAllocation()) {
3322 dominator_allocate->MakePrefillWithFiller(); 3322 dominator_allocate->MakePrefillWithFiller();
3323 } else { 3323 } else {
3324 // TODO(hpayer): This is a short-term hack to make allocation mementos 3324 // TODO(hpayer): This is a short-term hack to make allocation mementos
3325 // work again in new space. 3325 // work again in new space.
3326 ClearNextMapWord(original_object_size); 3326 dominator_allocate->ClearNextMapWord(original_object_size);
3327 } 3327 }
3328 #else 3328 #else
3329 // TODO(hpayer): This is a short-term hack to make allocation mementos 3329 // TODO(hpayer): This is a short-term hack to make allocation mementos
3330 // work again in new space. 3330 // work again in new space.
3331 ClearNextMapWord(original_object_size); 3331 dominator_allocate->ClearNextMapWord(original_object_size);
3332 #endif 3332 #endif
3333 3333
3334 dominator_allocate->clear_next_map_word_ = clear_next_map_word_; 3334 dominator_allocate->clear_next_map_word_ = clear_next_map_word_;
3335 3335
3336 // After that replace the dominated allocate instruction. 3336 // After that replace the dominated allocate instruction.
3337 HInstruction* dominated_allocate_instr = 3337 HInstruction* dominated_allocate_instr =
3338 HInnerAllocatedObject::New(zone, 3338 HInnerAllocatedObject::New(zone,
3339 context(), 3339 context(),
3340 dominator_allocate, 3340 dominator_allocate,
3341 dominator_size_constant, 3341 dominator_size_constant,
(...skipping 882 matching lines...) Expand 10 before | Expand all | Expand 10 after
4224 break; 4224 break;
4225 case kExternalMemory: 4225 case kExternalMemory:
4226 stream->Add("[external-memory]"); 4226 stream->Add("[external-memory]");
4227 break; 4227 break;
4228 } 4228 }
4229 4229
4230 stream->Add("@%d", offset()); 4230 stream->Add("@%d", offset());
4231 } 4231 }
4232 4232
4233 } } // namespace v8::internal 4233 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698