[ImportantSites] Limiting the # of Bookmark signals

[ImportantSites] Limiting the # of Bookmark signals

We don't want to include every bookmarked site as an important site as
there may be TONS. Here we try to limit them to 10 at most:
* If there are 5 or less, just use those as signals,
* Otherwise filter for bookmarks with site engagement > 0, sort &
  limit to 5.

R=tedchoc@chromium.org
BUG=649876
Committed: https://crrev.com/e11f01dc5c09c5e1eb4c748297a5a2c57e719b65
Cr-Commit-Position: refs/heads/master@{#421013}

[dmurph, 2016-09-23 23:54:57]

dmurph@chromium.org changed reviewers:
+ tedchoc@chromium.org

[dmurph, 2016-09-23 23:54:57]

Hi Ted,

This is an update to the bookmarks signal. I'm waiting on Dru & Rebecca for
confirmation on the logic here, but I think it's roughly right.

It's a little inefficient, but I hope it's clear what's happening. WDYT?

Thanks,
Daniel

[dmurph, 2016-09-23 23:55:12]

Description was changed from

==========
[ImportantSites] Limiting the # of Bookmark signals

We don't want to include every bookmarked site as an important site as
there may be TONS. Here we try to limit them to 10 at most:
* If there are 5 or less, just use those as signals,
* Otherwise filter for bookmarks with site engagement > 0, sort & limit
  to the top 10.

BUG=649876
==========

to

==========
[ImportantSites] Limiting the # of Bookmark signals

We don't want to include every bookmarked site as an important site as
there may be TONS. Here we try to limit them to 10 at most:
* If there are 5 or less, just use those as signals,
* Otherwise filter for bookmarks with site engagement > 0, sort & limit
  to the top 10.

R=tedchoc@chromium.org
BUG=649876
==========

[dmurph, 2016-09-26 20:36:59]

The CQ bit was checked by dmurph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 20:37:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ted C, 2016-09-26 20:54:54]

lgtm

[dmurph, 2016-09-26 21:15:21]

Description was changed from

==========
[ImportantSites] Limiting the # of Bookmark signals

We don't want to include every bookmarked site as an important site as
there may be TONS. Here we try to limit them to 10 at most:
* If there are 5 or less, just use those as signals,
* Otherwise filter for bookmarks with site engagement > 0, sort & limit
  to the top 10.

R=tedchoc@chromium.org
BUG=649876
==========

to

==========
[ImportantSites] Limiting the # of Bookmark signals

We don't want to include every bookmarked site as an important site as
there may be TONS. Here we try to limit them to 10 at most:
* If there are 5 or less, just use those as signals,
* Otherwise filter for bookmarks with site engagement > 0, sort & limit to 5.

R=tedchoc@chromium.org
BUG=649876
==========

[dmurph, 2016-09-26 21:15:32]

Description was changed from

==========
[ImportantSites] Limiting the # of Bookmark signals

We don't want to include every bookmarked site as an important site as
there may be TONS. Here we try to limit them to 10 at most:
* If there are 5 or less, just use those as signals,
* Otherwise filter for bookmarks with site engagement > 0, sort & limit to 5.

R=tedchoc@chromium.org
BUG=649876
==========

to

==========
[ImportantSites] Limiting the # of Bookmark signals

We don't want to include every bookmarked site as an important site as
there may be TONS. Here we try to limit them to 10 at most:
* If there are 5 or less, just use those as signals,
* Otherwise filter for bookmarks with site engagement > 0, sort &
  limit to 5.

R=tedchoc@chromium.org
BUG=649876
==========

[dmurph, 2016-09-26 21:15:48]

The CQ bit was unchecked by dmurph@chromium.org

[dmurph, 2016-09-26 21:15:51]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2016-09-26 21:16:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 22:05:43]

Description was changed from

==========
[ImportantSites] Limiting the # of Bookmark signals

We don't want to include every bookmarked site as an important site as
there may be TONS. Here we try to limit them to 10 at most:
* If there are 5 or less, just use those as signals,
* Otherwise filter for bookmarks with site engagement > 0, sort &
  limit to 5.

R=tedchoc@chromium.org
BUG=649876
==========

to

==========
[ImportantSites] Limiting the # of Bookmark signals

We don't want to include every bookmarked site as an important site as
there may be TONS. Here we try to limit them to 10 at most:
* If there are 5 or less, just use those as signals,
* Otherwise filter for bookmarks with site engagement > 0, sort &
  limit to 5.

R=tedchoc@chromium.org
BUG=649876
==========

[commit-bot: I haz the power, 2016-09-26 22:05:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-26 22:08:55]

Description was changed from

==========
[ImportantSites] Limiting the # of Bookmark signals

We don't want to include every bookmarked site as an important site as
there may be TONS. Here we try to limit them to 10 at most:
* If there are 5 or less, just use those as signals,
* Otherwise filter for bookmarks with site engagement > 0, sort &
  limit to 5.

R=tedchoc@chromium.org
BUG=649876
==========

to

==========
[ImportantSites] Limiting the # of Bookmark signals

We don't want to include every bookmarked site as an important site as
there may be TONS. Here we try to limit them to 10 at most:
* If there are 5 or less, just use those as signals,
* Otherwise filter for bookmarks with site engagement > 0, sort &
  limit to 5.

R=tedchoc@chromium.org
BUG=649876

Committed: https://crrev.com/e11f01dc5c09c5e1eb4c748297a5a2c57e719b65
Cr-Commit-Position: refs/heads/master@{#421013}
==========

[commit-bot: I haz the power, 2016-09-26 22:08:55]

Patchset 2 (id:??) landed as
https://crrev.com/e11f01dc5c09c5e1eb4c748297a5a2c57e719b65
Cr-Commit-Position: refs/heads/master@{#421013}