LayoutTests/http/tests/loading/preload-image-sizes-2x.html - Issue 236713005: Use SizesAttributeParser to get the right srcset resource

Unified Diff: LayoutTests/http/tests/loading/preload-image-sizes-2x.html

Issue 236713005: Use SizesAttributeParser to get the right srcset resource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sizes_parser8

Patch Set: Fixed review comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/loading/preload-image-sizes.html ('k') | LayoutTests/http/tests/loading/preload-image-sizes-2x-expected.txt » ('j') | Source/core/css/parser/SizesAttributeParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/loading/preload-image-sizes-2x.html

diff --git a/LayoutTests/http/tests/loading/preload-image-sizes-2x.html b/LayoutTests/http/tests/loading/preload-image-sizes-2x.html

new file mode 100644

index 0000000000000000000000000000000000000000..5134eb32a69a66f8fe62d56ed1f477f2c618ef80

--- /dev/null

+++ b/LayoutTests/http/tests/loading/preload-image-sizes-2x.html

@@ -0,0 +1,51 @@

+<html>

+<head>

+<script src="/js-test-resources/js-test.js"></script>

+<script>

+ window.targetScaleFactor = 2;

+</script>

+<script src="../resources/srcset-helper.js"></script>

+<script src="http://127.0.0.1:8000/resources/slow-script.pl?delay=100"></script>

+</head>

+<body>

+<script>

+ if (window.testRunner)

+ testRunner.dumpAsText();

+ shouldBeTrue("internals.isPreloaded('resources/image2.png');");

+ for (var i = 1; i <= 9; ++i) {

+ shouldBeFalse("internals.isPreloaded('resources/preload-test.jpg?" + i + "');");

+ shouldBeFalse("internals.isPreloaded('resources/base-image1.png?" + i + "');");

+ shouldBeTrue("internals.isPreloaded('resources/base-image2.png?" + i + "');");

+ shouldBeFalse("internals.isPreloaded('resources/base-image3.png?" + i + "');");

+ }

+ shouldBeFalse("internals.isPreloaded('resources/dup-image1.png?7');");

+ shouldBeFalse("internals.isPreloaded('resources/dup-image1.png?8');");

+ shouldBeFalse("internals.isPreloaded('resources/dup-image2.png?8');");

+ shouldBeFalse("internals.isPreloaded('resources/dup-image3.png?8');");

+ shouldBeFalse("internals.isPreloaded('resources/preload-test.jpg?10');");

+ shouldBeTrue("internals.isPreloaded('resources/base-image1.png?10');");

+ shouldBeFalse("internals.isPreloaded('resources/base-image2.png?10');");

+ shouldBeFalse("internals.isPreloaded('resources/base-image3.png?10');");

+</script>

+

+<img src="resources/image2.png">

+

+<img src="resources/preload-test.jpg?1" sizes="400px" srcset="resources/base-image1.png?1 200w, resources/base-image3.png?1 400w, resources/base-image2.png?1 800w">

+<img src="resources/preload-test.jpg?2" srcset="resources/base-image1.png?2 200w, resources/base-image3.png?2 400w, resources/base-image2.png?2 800w" sizes="400px">

+<img sizes="400px" src="resources/preload-test.jpg?3" srcset="resources/base-image1.png?3 200w, resources/base-image3.png?3 400w, resources/base-image2.png?3 800w">

+<img sizes="400px" srcset="resources/base-image1.png?4 200w, resources/base-image3.png?4 400w, resources/base-image2.png?4 800w" src="resources/preload-test.jpg?4">

+<img srcset="resources/base-image1.png?5 200w, resources/base-image3.png?5 400w, resources/base-image2.png?5 800w" src="resources/preload-test.jpg?5" sizes="400px">

+<img srcset="resources/base-image1.png?6 200w, resources/base-image3.png?6 400w, resources/base-image2.png?6 800w" sizes="400px" src="resources/preload-test.jpg?6">

+

+<img srcset="resources/base-image1.png?7 200w, resources/base-image3.png?7 400w, resources/base-image2.png?7 800w" sizes="400px" src="resources/preload-test.jpg?7"

+ src="resources/dup-image1.png?7">

+<img srcset="resources/base-image1.png?8 200w, resources/base-image3.png?8 400w, resources/base-image2.png?8 800w" sizes="400px" src="resources/preload-test.jpg?8"

+ srcset="resources/dup-image1.png?8 200w, resources/dup-image3.png?8 400w, resources/dup-image2.png?8 800w">

+<img srcset="resources/base-image1.png?9 200w, resources/base-image3.png?9 400w, resources/base-image2.png?9 800w" sizes="400px" src="resources/preload-test.jpg?9"

+ sizes="800px">

+

+<img srcset="resources/base-image1.png?10 2x, resources/base-image3.png?10 4x, resources/base-image2.png?10 8x" sizes="400px" src="resources/preload-test.jpg?10">

+</body>

+</html>