Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: Source/core/css/parser/SizesAttributeParser.cpp

Issue 236713005: Use SizesAttributeParser to get the right srcset resource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sizes_parser8
Patch Set: Fixed nits Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "SizesAttributeParser.h" 6 #include "SizesAttributeParser.h"
7 7
8 #include "MediaTypeNames.h" 8 #include "MediaTypeNames.h"
9 #include "core/css/MediaQueryEvaluator.h" 9 #include "core/css/MediaQueryEvaluator.h"
10 #include "core/css/parser/MediaQueryTokenizer.h" 10 #include "core/css/parser/MediaQueryTokenizer.h"
(...skipping 11 matching lines...) Expand all
22 return parser.effectiveSize(); 22 return parser.effectiveSize();
23 } 23 }
24 24
25 bool SizesAttributeParser::calculateLengthInPixels(TokenIterator startToken, Tok enIterator endToken, unsigned& result) 25 bool SizesAttributeParser::calculateLengthInPixels(TokenIterator startToken, Tok enIterator endToken, unsigned& result)
26 { 26 {
27 MediaQueryTokenType type = startToken->type(); 27 MediaQueryTokenType type = startToken->type();
28 if (type == DimensionToken) { 28 if (type == DimensionToken) {
29 int length; 29 int length;
30 if (!CSSPrimitiveValue::isLength(startToken->unitType())) 30 if (!CSSPrimitiveValue::isLength(startToken->unitType()))
31 return false; 31 return false;
32 if (m_mediaValues->computeLength(startToken->numericValue(), startToken- >unitType(), length)) { 32 if ((m_mediaValues->computeLength(startToken->numericValue(), startToken ->unitType(), length)) && (length > 0)) {
33 if (length > 0) { 33 result = (unsigned)length;
34 result = (unsigned)length; 34 return true;
35 return true;
36 }
37 } 35 }
38 } 36 }
39 if (type == FunctionToken) { 37 // FIXME - Handle calc() FunctionToken here!
40 // FIXME - Handle calc() functions here!
41 }
42 return false; 38 return false;
43 } 39 }
44 40
45 static void reverseSkipIrrelevantTokens(TokenIterator& token, TokenIterator star tToken) 41 static void reverseSkipIrrelevantTokens(TokenIterator& token, TokenIterator star tToken)
46 { 42 {
47 TokenIterator endToken = token; 43 TokenIterator endToken = token;
48 while (token != startToken && (token->type() == WhitespaceToken || token->ty pe() == CommentToken || token->type() == EOFToken)) 44 while (token != startToken && (token->type() == WhitespaceToken || token->ty pe() == CommentToken || token->type() == EOFToken))
49 --token; 45 --token;
50 if (token != endToken) 46 if (token != endToken)
51 ++token; 47 ++token;
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 RefPtrWillBeRawPtr<MediaQuerySet> mediaCondition = MediaQueryParser::parseMe diaCondition(startToken, endToken); 90 RefPtrWillBeRawPtr<MediaQuerySet> mediaCondition = MediaQueryParser::parseMe diaCondition(startToken, endToken);
95 if (mediaCondition && mediaConditionMatches(mediaCondition)) { 91 if (mediaCondition && mediaConditionMatches(mediaCondition)) {
96 m_length = length; 92 m_length = length;
97 return true; 93 return true;
98 } 94 }
99 return false; 95 return false;
100 } 96 }
101 97
102 bool SizesAttributeParser::parse(Vector<MediaQueryToken>& tokens) 98 bool SizesAttributeParser::parse(Vector<MediaQueryToken>& tokens)
103 { 99 {
100 if (tokens.isEmpty())
101 return false;
104 TokenIterator startToken = tokens.begin(); 102 TokenIterator startToken = tokens.begin();
105 TokenIterator endToken; 103 TokenIterator endToken;
106 // Split on a comma token, and send the result tokens to be parsed as (media -condition, length) pairs 104 // Split on a comma token, and send the result tokens to be parsed as (media -condition, length) pairs
107 for (TokenIterator token = tokens.begin(); token != tokens.end(); ++token) { 105 for (TokenIterator token = tokens.begin(); token != tokens.end(); ++token) {
108 if (token->type() == CommaToken) { 106 if (token->type() == CommaToken) {
109 endToken = token; 107 endToken = token;
110 if (parseMediaConditionAndLength(startToken, endToken)) 108 if (parseMediaConditionAndLength(startToken, endToken))
111 return true; 109 return true;
112 startToken = token; 110 startToken = token;
113 ++startToken; 111 ++startToken;
(...skipping 11 matching lines...) Expand all
125 } 123 }
126 124
127 unsigned SizesAttributeParser::effectiveSizeDefaultValue() 125 unsigned SizesAttributeParser::effectiveSizeDefaultValue()
128 { 126 {
129 // Returning the equivalent of "100%" 127 // Returning the equivalent of "100%"
130 return m_mediaValues->viewportWidth(); 128 return m_mediaValues->viewportWidth();
131 } 129 }
132 130
133 } // namespace 131 } // namespace
134 132
OLDNEW
« no previous file with comments | « Source/core/css/parser/MediaQueryTokenizer.cpp ('k') | Source/core/css/parser/SizesAttributeParserTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698