LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change.html - Issue 236713005: Use SizesAttributeParser to get the right srcset resource

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change.html

Issue 236713005: Use SizesAttributeParser to get the right srcset resource (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sizes_parser8

Patch Set: Fixed nits Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLImageElement/image-sizes-invalid-length-expected.txt ('k') | LayoutTests/fast/dom/HTMLImageElement/image-sizes-js-change-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../hidpi/resources/srcset-helper.js"></script>

	4 <script src="../../../resources/js-test.js"></script>

	5 <script>

	6 if (window.testRunner)

	7 testRunner.dumpAsText();

	8

	9 function updateSrc() {

	10 var img = document.getElementById("foo");

	11 // sizes must be set first, then srcset must be set, the 'src'

	12 // This will be fixed when image loading is done is "stable-state"

	13 img.sizes = "400px";

	14 img.srcset = "../../hidpi/resources/image-set-1x.png 200w, ../../hidpi/r esources/image-set-2x.png 400w, resources/image-set-4x.png 800w";

	15 img.src = "resources/blue-100-px-square.png"

	16 }

	17

	18 addEventListener("DOMContentLoaded", function() {

	19 if (window.testRunner && sessionStorage.pageReloaded)

	20 testRunner.dumpResourceRequestCallbacks();

	21 updateSrc();

	22 }, false);

	23 addEventListener("load", function() {

	24 shouldBe('document.getElementById("foo").currentSrc', '"resources/image- set-4x.png"');

	25 }, false);

	26 </script>

	27 </head>

	28

	29 <body id="body">

	30 <img id="foo">

	31 </body>

	32 </html>

OLD	NEW