Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 236713003: [ServiceWorker, PushMessaging] Use ScriptPromiseResolverWithContext. (Closed)

Created:
6 years, 8 months ago by yhirano
Modified:
6 years, 7 months ago
CC:
blink-reviews, Nils Barth (inactive), jsbell+serviceworker_chromium.org, serviceworker-reviews, arv+blink, jsbell+bindings_chromium.org, tzik, sof, kouhei+bindings_chromium.org, nhiroki, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, falken, horo+watch_chromium.org, Nate Chapin, alecflett+watch_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[ServiceWorker, PushMessaging] Use ScriptPromiseResolverWithContext. Use ScriptPromiseResolverWithContext instead of a pair of ScriptPromiseResolver and NewScriptState. This CL doen't change the behavior in many cases: The only exception is when the resolution / rejection happens on the suspended or stopped ExecutionContext. In such a case, ScriptPromiseResolver suspends or stops resolution or rejection. R=dominicc@chromium.org, mvanouwerkerk@chromium.org TBR=mvanouwerkerk@chromium.org BUG=352552 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172011

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M Source/bindings/v8/CallbackPromiseAdapter.h View 1 2 3 2 chunks +7 lines, -10 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseResolverWithContext.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptPromiseResolverWithContext.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/push_messaging/PushManager.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
yhirano
6 years, 8 months ago (2014-04-14 11:55:40 UTC) #1
haraken
https://codereview.chromium.org/236713003/diff/20001/Source/bindings/v8/CallbackPromiseAdapter.h File Source/bindings/v8/CallbackPromiseAdapter.h (right): https://codereview.chromium.org/236713003/diff/20001/Source/bindings/v8/CallbackPromiseAdapter.h#newcode75 Source/bindings/v8/CallbackPromiseAdapter.h:75: return; This will change existing behavior in a case ...
6 years, 8 months ago (2014-04-14 12:13:16 UTC) #2
yhirano
https://codereview.chromium.org/236713003/diff/20001/Source/bindings/v8/CallbackPromiseAdapter.h File Source/bindings/v8/CallbackPromiseAdapter.h (right): https://codereview.chromium.org/236713003/diff/20001/Source/bindings/v8/CallbackPromiseAdapter.h#newcode75 Source/bindings/v8/CallbackPromiseAdapter.h:75: return; On 2014/04/14 12:13:17, haraken wrote: > > This ...
6 years, 8 months ago (2014-04-14 12:37:23 UTC) #3
dominicc (has gone to gerrit)
I *think* ServiceWorker can live with this, but there's one detail I'm not sure about. ...
6 years, 8 months ago (2014-04-15 00:22:15 UTC) #4
yhirano
https://codereview.chromium.org/236713003/diff/20001/Source/bindings/v8/CallbackPromiseAdapter.h File Source/bindings/v8/CallbackPromiseAdapter.h (right): https://codereview.chromium.org/236713003/diff/20001/Source/bindings/v8/CallbackPromiseAdapter.h#newcode75 Source/bindings/v8/CallbackPromiseAdapter.h:75: return; On 2014/04/14 12:37:23, yhirano wrote: > On 2014/04/14 ...
6 years, 8 months ago (2014-04-15 01:02:17 UTC) #5
yhirano
On 2014/04/15 00:22:15, dominicc wrote: > I *think* ServiceWorker can live with this, but there's ...
6 years, 8 months ago (2014-04-15 01:11:22 UTC) #6
haraken
LGTM in terms of implementation.
6 years, 8 months ago (2014-04-15 01:27:46 UTC) #7
dominicc (has gone to gerrit)
On 2014/04/15 01:27:46, haraken wrote: > LGTM in terms of implementation. LGTM too, I'm not ...
6 years, 8 months ago (2014-04-15 02:22:41 UTC) #8
yhirano
+kinuko for OWNER review
6 years, 8 months ago (2014-04-15 02:30:22 UTC) #9
kinuko
lgtm
6 years, 8 months ago (2014-04-15 02:31:12 UTC) #10
yhirano
mvanouwerkerk: ping
6 years, 8 months ago (2014-04-16 13:26:00 UTC) #11
yhirano
mvanouwerkerk: ping
6 years, 8 months ago (2014-04-18 15:44:17 UTC) #12
dominicc (has gone to gerrit)
I think it is safe to TBR mvanouwerkerk since you wrote this bit of infrastructure ...
6 years, 8 months ago (2014-04-21 03:38:32 UTC) #13
yhirano
On 2014/04/21 03:38:32, dominicc wrote: > I think it is safe to TBR mvanouwerkerk since ...
6 years, 8 months ago (2014-04-21 04:55:29 UTC) #14
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 8 months ago (2014-04-21 04:55:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/236713003/50001
6 years, 8 months ago (2014-04-21 04:55:43 UTC) #16
commit-bot: I haz the power
Change committed as 172011
6 years, 8 months ago (2014-04-21 05:04:45 UTC) #17
Michael van Ouwerkerk
6 years, 7 months ago (2014-04-29 16:46:15 UTC) #18
Message was sent while issue was closed.
On 2014/04/21 05:04:45, I haz the power (commit-bot) wrote:
> Change committed as 172011

Apologies for the non-response, I was OOO. lgtm

Powered by Google App Engine
This is Rietveld 408576698