Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 236713002: Implement net in GN build. (Closed)

Created:
6 years, 8 months ago by brettw
Modified:
6 years, 8 months ago
Reviewers:
tfarina, scottmg
CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Implement net in GN build. This does the net target. I started doing some more that are commented out at the bottom, and there are a few more after that do do. The deps of these targets started to build up to an unreasonable level and this should be a good checkpoint. Fix grit rule. Fix SSL dependent configs Add TLD cleanup Add gconf and gio targets for Linux. Add sources filtering for ChromeOS, .rc, and .mm files. Remove built-in code that removes .rc and .mm files (this wasn't quite complete so causes problems). BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263967

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+673 lines, -37 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M base/BUILD.gn View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 3 chunks +11 lines, -0 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +50 lines, -0 lines 0 comments Download
M crypto/BUILD.gn View 1 2 1 chunk +9 lines, -1 line 0 comments Download
A net/BUILD.gn View 1 2 1 chunk +572 lines, -0 lines 0 comments Download
M net/net.gypi View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/BUILD.gn View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
A + net/tools/tld_cleanup/BUILD.gn View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tools/gn/ninja_helper.cc View 1 1 chunk +8 lines, -15 lines 0 comments Download
M tools/gn/secondary/tools/grit/grit_rule.gni View 1 4 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
Depends on https://codereview.chromium.org/231673006/
6 years, 8 months ago (2014-04-14 18:34:28 UTC) #1
tfarina
Thanks for fixing the grit template Brett. https://codereview.chromium.org/236713002/diff/20001/net/tools/tld_cleanup/BUILD.gn File net/tools/tld_cleanup/BUILD.gn (right): https://codereview.chromium.org/236713002/diff/20001/net/tools/tld_cleanup/BUILD.gn#newcode5 net/tools/tld_cleanup/BUILD.gn:5: source_set("tld_cleanup") { ...
6 years, 8 months ago (2014-04-14 19:04:02 UTC) #2
scottmg
lgtm https://codereview.chromium.org/236713002/diff/20001/net/net.gypi File net/net.gypi (right): https://codereview.chromium.org/236713002/diff/20001/net/net.gypi#newcode7 net/net.gypi:7: # that beyond the simle one-level-deep dictionary of ...
6 years, 8 months ago (2014-04-14 19:07:10 UTC) #3
brettw
6 years, 8 months ago (2014-04-15 19:26:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r263967.

Powered by Google App Engine
This is Rietveld 408576698