Source/web/WebSharedWorkerImpl.cpp - Issue 23671002: Refactoring: Add toWebFrameImpl() interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSharedWorkerImpl.cpp

Issue 23671002: Refactoring: Add toWebFrameImpl() interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Corrected as per review commments. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebSharedWorkerImpl.cpp

diff --git a/Source/web/WebSharedWorkerImpl.cpp b/Source/web/WebSharedWorkerImpl.cpp

index 59d9ef1681d6d8e0bca71bb21c335abf965f7a10..7ebf42246e834898236cad95c032fc3aaf10ab29 100644

--- a/Source/web/WebSharedWorkerImpl.cpp

+++ b/Source/web/WebSharedWorkerImpl.cpp

@@ -102,7 +102,7 @@ WebSharedWorkerImpl::WebSharedWorkerImpl(WebSharedWorkerClient* client)

WebSharedWorkerImpl::~WebSharedWorkerImpl()

{

ASSERT(m_webView);

- WebFrameImpl* webFrame = static_cast<WebFrameImpl*>(m_webView->mainFrame());

+ WebFrameImpl* webFrame = toWebFrameImpl(m_webView->mainFrame());

if (webFrame)

webFrame->setClient(0);

m_webView->close();

@@ -129,7 +129,7 @@ void WebSharedWorkerImpl::initializeLoader(const WebURL& url)

// is created (similar to RenderThread::OnCreateNewView).

m_webView->initializeMainFrame(this);

- WebFrameImpl* webFrame = static_cast<WebFrameImpl*>(m_webView->mainFrame());

+ WebFrameImpl* webFrame = toWebFrameImpl(m_webView->mainFrame());

// Construct substitute data source for the 'shadow page'. We only need it

// to have same origin as the worker so the loading checks work correctly.

« no previous file with comments | « Source/web/WebRange.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »