Refactoring: Add toWebFrameImpl() interface.

Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 2062 matching lines @@
     m_webView->layout();
     runPendingTasks();
 
     // Note that the 'result 19' in the <select> element is not expected to produce a match.
     static const char* kFindString = "result";
     static const int kFindIdentifier = 12345;
     static const int kNumResults = 19;
 
     WebFindOptions options;
     WebString searchText = WebString::fromUTF8(kFindString);
-    WebFrameImpl* mainFrame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
+    WebFrameImpl* mainFrame = toWebFrameImpl(m_webView->mainFrame());
     EXPECT_TRUE(mainFrame->find(kFindIdentifier, searchText, options, false, 0));
 
     mainFrame->resetMatchCount();
 
     for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false))
         frame->scopeStringMatches(kFindIdentifier, searchText, options, true);
 
     runPendingTasks();
     EXPECT_TRUE(client.findResultsAreReady());
 
@@ skipping 98 matching lines @@
     m_webView->resize(WebSize(640, 480));
     m_webView->layout();
     runPendingTasks();
 
     static const char* kFindString = "hello";
     static const int kFindIdentifier = 12345;
     static const int kNumResults = 1;
 
     WebFindOptions options;
     WebString searchText = WebString::fromUTF8(kFindString);
-    WebFrameImpl* mainFrame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
+    WebFrameImpl* mainFrame = toWebFrameImpl(m_webView->mainFrame());
     EXPECT_TRUE(mainFrame->find(kFindIdentifier, searchText, options, false, 0));
 
     mainFrame->resetMatchCount();
 
     for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false))
         frame->scopeStringMatches(kFindIdentifier, searchText, options, true);
 
     runPendingTasks();
     EXPECT_TRUE(client.findResultsAreReady());
     EXPECT_EQ(kNumResults, client.count());
@@ skipping 11 matching lines @@
     m_webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "find_in_page.html", true, &client);
     m_webView->resize(WebSize(640, 480));
     m_webView->layout();
     runPendingTasks();
 
     static const char* kFindString = "result";
     static const int kFindIdentifier = 12345;
 
     WebFindOptions options;
     WebString searchText = WebString::fromUTF8(kFindString);
-    WebFrameImpl* mainFrame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
-    WebFrameImpl* secondFrame = static_cast<WebFrameImpl*>(mainFrame->traverseNext(false));
+    WebFrameImpl* mainFrame = toWebFrameImpl(m_webView->mainFrame());
+    WebFrameImpl* secondFrame = toWebFrameImpl(mainFrame->traverseNext(false));
     RefPtr<WebCore::Frame> holdSecondFrame = secondFrame->frame();
 
     // Detach the frame before finding.
     EXPECT_TRUE(mainFrame->document().getElementById("frame").remove());
 
     EXPECT_TRUE(mainFrame->find(kFindIdentifier, searchText, options, false, 0));
     EXPECT_FALSE(secondFrame->find(kFindIdentifier, searchText, options, false, 0));
 
     runPendingTasks();
     EXPECT_FALSE(client.findResultsAreReady());
@@ skipping 21 matching lines @@
     m_webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "find_in_page.html", true, &client);
     m_webView->resize(WebSize(640, 480));
     m_webView->layout();
     runPendingTasks();
 
     static const char* kFindString = "result";
     static const int kFindIdentifier = 12345;
 
     WebFindOptions options;
     WebString searchText = WebString::fromUTF8(kFindString);
-    WebFrameImpl* mainFrame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
-    WebFrameImpl* secondFrame = static_cast<WebFrameImpl*>(mainFrame->traverseNext(false));
+    WebFrameImpl* mainFrame = toWebFrameImpl(m_webView->mainFrame());
+    WebFrameImpl* secondFrame = toWebFrameImpl(mainFrame->traverseNext(false));
     RefPtr<WebCore::Frame> holdSecondFrame = secondFrame->frame();
 
     for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false))
         EXPECT_TRUE(frame->find(kFindIdentifier, searchText, options, false, 0));
 
     runPendingTasks();
     EXPECT_FALSE(client.findResultsAreReady());
 
     // Detach the frame between finding and scoping.
     EXPECT_TRUE(mainFrame->document().getElementById("frame").remove());
@@ skipping 21 matching lines @@
     m_webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "find_in_page.html", true, &client);
     m_webView->resize(WebSize(640, 480));
     m_webView->layout();
     runPendingTasks();
 
     static const char* kFindString = "result";
     static const int kFindIdentifier = 12345;
 
     WebFindOptions options;
     WebString searchText = WebString::fromUTF8(kFindString);
-    WebFrameImpl* mainFrame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
-    WebFrameImpl* secondFrame = static_cast<WebFrameImpl*>(mainFrame->traverseNext(false));
+    WebFrameImpl* mainFrame = toWebFrameImpl(m_webView->mainFrame());
+    WebFrameImpl* secondFrame = toWebFrameImpl(mainFrame->traverseNext(false));
     RefPtr<WebCore::Frame> holdSecondFrame = secondFrame->frame();
 
     for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false))
         EXPECT_TRUE(frame->find(kFindIdentifier, searchText, options, false, 0));
 
     runPendingTasks();
     EXPECT_FALSE(client.findResultsAreReady());
 
     mainFrame->resetMatchCount();
 
@@ skipping 272 matching lines @@
 {
     return WebCore::VisiblePosition(renderer->positionForPoint(WebCore::LayoutPoint(x, y))).deepEquivalent().computeOffsetInContainerNode();
 }
 
 // positionForPoint returns the wrong values for contenteditable spans. See
 // http://crbug.com/238334.
 TEST_F(WebFrameTest, DISABLED_PositionForPointTest)
 {
     registerMockedHttpURLLoad("select_range_span_editable.html");
     m_webView = createWebViewForTextSelection(m_baseURL + "select_range_span_editable.html");
-    WebFrameImpl* mainFrame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
+    WebFrameImpl* mainFrame = toWebFrameImpl(m_webView->mainFrame());
     WebCore::RenderObject* renderer = mainFrame->frame()->selection()->rootEditableElement()->renderer();
     EXPECT_EQ(0, computeOffset(renderer, -1, -1));
     EXPECT_EQ(64, computeOffset(renderer, 1000, 1000));
 
     registerMockedHttpURLLoad("select_range_div_editable.html");
     m_webView = createWebViewForTextSelection(m_baseURL + "select_range_div_editable.html");
-    mainFrame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
+    mainFrame = toWebFrameImpl(m_webView->mainFrame());
     renderer = mainFrame->frame()->selection()->rootEditableElement()->renderer();
     EXPECT_EQ(0, computeOffset(renderer, -1, -1));
     EXPECT_EQ(64, computeOffset(renderer, 1000, 1000));
 }
 
 #if !OS(DARWIN)
 TEST_F(WebFrameTest, SelectRangeStaysHorizontallyAlignedWhenMoved)
 {
     WebFrameImpl* frame;
     registerMockedHttpURLLoad("move_caret.html");
@@ skipping 411 matching lines @@
     uint32_t m_hash;
 };
 
 TEST_F(WebFrameTest, ReplaceMisspelledRange)
 {
     registerMockedHttpURLLoad("spell.html");
     m_webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "spell.html");
     SpellCheckClient spellcheck;
     m_webView->setSpellCheckClient(&spellcheck);
 
-    WebFrameImpl* frame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
+    WebFrameImpl* frame = toWebFrameImpl(m_webView->mainFrame());
     Document* document = frame->frame()->document();
     Element* element = document->getElementById("data");
 
     m_webView->settings()->setAsynchronousSpellCheckingEnabled(true);
     m_webView->settings()->setUnifiedTextCheckerEnabled(true);
     m_webView->settings()->setEditingBehavior(WebSettings::EditingBehaviorWin);
 
     element->focus();
     document->execCommand("InsertText", false, "_wellcome_.");
 
@@ skipping 12 matching lines @@
     m_webView = 0;
 }
 
 TEST_F(WebFrameTest, RemoveSpellingMarkers)
 {
     registerMockedHttpURLLoad("spell.html");
     m_webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "spell.html");
     SpellCheckClient spellcheck;
     m_webView->setSpellCheckClient(&spellcheck);
 
-    WebFrameImpl* frame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
+    WebFrameImpl* frame = toWebFrameImpl(m_webView->mainFrame());
     Document* document = frame->frame()->document();
     Element* element = document->getElementById("data");
 
     m_webView->settings()->setAsynchronousSpellCheckingEnabled(true);
     m_webView->settings()->setUnifiedTextCheckerEnabled(true);
     m_webView->settings()->setEditingBehavior(WebSettings::EditingBehaviorWin);
 
     element->focus();
     document->execCommand("InsertText", false, "_wellcome_.");
 
@@ skipping 11 matching lines @@
 }
 
 TEST_F(WebFrameTest, MarkerHashIdentifiers) {
     registerMockedHttpURLLoad("spell.html");
     m_webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "spell.html");
 
     static const uint32_t kHash = 42;
     SpellCheckClient spellcheck(kHash);
     m_webView->setSpellCheckClient(&spellcheck);
 
-    WebFrameImpl* frame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
+    WebFrameImpl* frame = toWebFrameImpl(m_webView->mainFrame());
     Document* document = frame->frame()->document();
     Element* element = document->getElementById("data");
 
     m_webView->settings()->setAsynchronousSpellCheckingEnabled(true);
     m_webView->settings()->setUnifiedTextCheckerEnabled(true);
     m_webView->settings()->setEditingBehavior(WebSettings::EditingBehaviorWin);
 
     element->focus();
     document->execCommand("InsertText", false, "wellcome.");
 
@@ skipping 37 matching lines @@
 };
 
 TEST_F(WebFrameTest, SlowSpellcheckMarkerPosition)
 {
     registerMockedHttpURLLoad("spell.html");
     m_webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "spell.html");
 
     StubbornSpellCheckClient spellcheck;
     m_webView->setSpellCheckClient(&spellcheck);
 
-    WebFrameImpl* frame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
+    WebFrameImpl* frame = toWebFrameImpl(m_webView->mainFrame());
     WebInputElement webInputElement = frame->document().getElementById("data").to<WebInputElement>();
     Document* document = frame->frame()->document();
     Element* element = document->getElementById("data");
 
     m_webView->settings()->setAsynchronousSpellCheckingEnabled(true);
     m_webView->settings()->setUnifiedTextCheckerEnabled(true);
     m_webView->settings()->setEditingBehavior(WebSettings::EditingBehaviorWin);
 
     element->focus();
     document->execCommand("InsertText", false, "wellcome ");
@@ skipping 11 matching lines @@
 }
 
 // This test verifies that cancelling spelling request does not cause a
 // write-after-free when there's no spellcheck client set.
 TEST_F(WebFrameTest, CancelSpellingRequestCrash)
 {
     registerMockedHttpURLLoad("spell.html");
     m_webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "spell.html");
     m_webView->setSpellCheckClient(0);
 
-    WebFrameImpl* frame = static_cast<WebFrameImpl*>(m_webView->mainFrame());
+    WebFrameImpl* frame = toWebFrameImpl(m_webView->mainFrame());
     Document* document = frame->frame()->document();
     Element* element = document->getElementById("data");
 
     m_webView->settings()->setAsynchronousSpellCheckingEnabled(true);
     m_webView->settings()->setUnifiedTextCheckerEnabled(true);
     m_webView->settings()->setEditingBehavior(WebSettings::EditingBehaviorWin);
 
     element->focus();
     frame->frame()->editor().replaceSelectionWithText("A", false, false);
     frame->frame()->editor().spellCheckRequester().cancelCheck();
@@ skipping 97 matching lines @@
     }
     bool wasUserScroll() const { return m_didScrollMainFrame && !m_wasProgrammaticScroll; }
     bool wasProgrammaticScroll() const { return m_didScrollMainFrame && m_wasProgrammaticScroll; }
 
     // WebFrameClient:
     virtual void didChangeScrollOffset(WebFrame* frame) OVERRIDE
     {
         if (frame->parent())
             return;
         EXPECT_FALSE(m_didScrollMainFrame);
-        WebCore::FrameView* view = static_cast<WebFrameImpl*>(frame)->frameView();
+        WebCore::FrameView* view = toWebFrameImpl(frame)->frameView();
         // FrameView can be scrolled in FrameView::setFixedVisibleContentRect
         // which is called from Frame::createView (before the frame is associated
         // with the the view).
         if (view) {
             m_didScrollMainFrame = true;
             m_wasProgrammaticScroll = view->inProgrammaticScroll();
         }
     }
 private:
     bool m_didScrollMainFrame;
@@ skipping 164 matching lines @@
 
 class TestSameDocumentWebFrameClient : public WebFrameClient {
 public:
     TestSameDocumentWebFrameClient()
         : m_frameLoadTypeSameSeen(false)
     {
     }
 
     virtual void willSendRequest(WebFrame* frame, unsigned, WebURLRequest&, const WebURLResponse&)
     {
-        if (static_cast<WebFrameImpl*>(frame)->frame()->loader()->loadType() == WebCore::FrameLoadTypeSame)
+        if (toWebFrameImpl(frame)->frame()->loader()->loadType() == WebCore::FrameLoadTypeSame)
             m_frameLoadTypeSameSeen = true;
     }
 
     bool frameLoadTypeSameSeen() const { return m_frameLoadTypeSameSeen; }
 
 private:
     bool m_frameLoadTypeSameSeen;
 };
 
 TEST_F(WebFrameTest, NavigateToSame)
@@ skipping 71 matching lines @@
     m_webView = FrameTestHelpers::createWebViewAndLoad(m_baseURL + "push_state.html", true, 0, &client);
     runPendingTasks();
 
     EXPECT_EQ(client.startLoadingCount(), 2);
     EXPECT_EQ(client.stopLoadingCount(), 2);
     m_webView->close();
     m_webView = 0;
 }
 
 } // namespace